Fix XL failures in finalize step of peadm::convert #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the finalize step of `peadm::convert` would
fail when operating on PE XL installations as the Primary Database
and Replica Database nodes do not run the pe-puppetdb or pe-puppetserver
services:
```
The command failed with exit code 5
STDERR:
Failed to restart pe-puppetserver.service: Unit not found.
Failed to restart pe-puppetdb.service: Unit not found.
```
This commit updates the convert plan to exclude the database
nodes from that service restart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the finalize step of
peadm::convertwould fail when operating on PE XL installations as the Primary Database and Replica Database nodes do not run the pe-puppetdb or pe-puppetserver services:This commit updates the convert plan to exclude the database nodes from that service restart.