support configurable installer target upload path #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0tw1r3
force-pushed
the
uploaddir-support
branch
from
5b11f04 to
5ad16dd
Compare
|
Hi @h0tw1r3, is it possible to rebase and have a look those conflicts please? |
Upload path was hard-coded to /tmp. Very large files can be problematic as it is memory backed and typically not limited by default. With ~1.4G used by the PE installer, unexpected bolt failures on systems with low to no swap occur (high performance or containers).
h0tw1r3
force-pushed
the
uploaddir-support
branch
from
5ad16dd to
9c74a7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload path was hard-coded to /tmp. Very large files can be problematic as it is memory backed and typically not limited by default. With ~1.4G used by the PE installer, unexpected bolt failures on systems with low to no swap occur (high performance or containers).