Skip to content

(PE-37236) Remove experimental status of add_compiler #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Jo-Lillie
Copy link
Contributor

@Jo-Lillie Jo-Lillie commented Apr 11, 2024

Summary

Remove experimental status of add_compiler plan, change to public and update reference.md

Additional Context

Jira ticket

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@Jo-Lillie Jo-Lillie requested review from a team as code owners April 11, 2024 14:27
@CoMfUcIoS CoMfUcIoS merged commit c2a0c61 into add_compiler_supported Apr 11, 2024
4 checks passed
@CoMfUcIoS CoMfUcIoS deleted the pe-37236-remove-experimental-status-of-add-compiler branch April 11, 2024 14:32
CoMfUcIoS added a commit that referenced this pull request Sep 12, 2024
* (PE-37236) Remove experimental status of add_compiler (#428)

* (PE-37233) Adding add_compiler to test matrix (#434)

Updated add_compiler spec to check compiler has been added and puppet run before running add compiler
Added test matrix for add compiler

* (PE-38814) add_compiler - Making primary_postgresql_host and avail_group_letter optional (#468)

* (PE-38814) add_compiler - Making primary_postgresql_host and avail_group_letter optional

primary_postgresql_host, if not provided will be determined through get_peadm_config
avail_group_letter, is defaulting to A

* Updating spec tests for add compiler

Removing optional from avail_group_letter as not required with enum default value

* Updating reference.md

* Fixing linting issues

---------

Co-authored-by: Neil Anderson <[email protected]>

* (PE-37235) Verify and update documentation on add_compiler (#429)

* PE-37235 Verify and update documentation on add_compiler if needed and its experimental status

* @cathal41
PE-37235 Verify and update documentation on add_compiler - wording updates

* Update plans/add_compiler.pp

Co-authored-by: Dimitri Tischenko <[email protected]>

* Update documentation/add_compiler.md

Co-authored-by: Dimitri Tischenko <[email protected]>

* Update documentation/add_compiler.md

Co-authored-by: Dimitri Tischenko <[email protected]>

* Update documentation/add_compiler.md

Co-authored-by: Dimitri Tischenko <[email protected]>

* Update documentation/add_compiler.md

Co-authored-by: Dimitri Tischenko <[email protected]>

* Update documentation/add_compiler.md

Co-authored-by: Dimitri Tischenko <[email protected]>

* Updating add compiler docs to show optional params

* Updating docs with text corrections

---------

Co-authored-by: Dimitri Tischenko <[email protected]>
Co-authored-by: Neil Anderson <[email protected]>

* chore(workflows): simplify YAML syntax and improve readability

- Removed unnecessary quotes around strings in YAML files.
- Consolidated list items to single-line format where applicable.
- Ensured consistent naming conventions for job steps.
- Improved readability by removing extra blank lines.

* fix(workflow): add console_password to test-add-compiler workflows

- Added `console_password` parameter to the `test-add-compiler-matrix.yml` and `test-add-compiler.yaml` workflows.
- This ensures the console password is passed correctly during the workflow execution.

* chore: update test-add-compiler-matrix workflow

- Remove centos-7 from the image matrix in test-add-compiler-matrix.yml
- Retain only almalinux-cloud/almalinux-8 in the image matrix

* feat(workflow): add --stream option to bolt plan run command

Added the --stream option to the bolt plan run command in the test-add-compiler GitHub workflow. This change ensures that the output is streamed in real-time.

* chore(workflow): update compiler versions in test-add-compiler-matrix.yml

Updated the compiler versions in the test-add-compiler-matrix.yml GitHub workflow from 2021.7.7 and 2023.6.0 to 2021.7.9 and 2023.8.0.

---------

Co-authored-by: Jo Lillie <[email protected]>
Co-authored-by: Neil Anderson <[email protected]>
Co-authored-by: Neil Anderson <[email protected]>
Co-authored-by: cathal41 <[email protected]>
Co-authored-by: Dimitri Tischenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants