PE-38219 - Support air gapped installation while using a Windows as Jump host #438
Conversation
cathal41
changed the title
| @@ -0,0 +1,9 @@ | |||
| { | |||
There was a problem hiding this comment.
is the whole task required? can't you use https://forge.puppet.com/modules/puppetlabs/facts/readme ?
There was a problem hiding this comment.
Tried to run factor with operatingsystem but because this is an install some people may not have run puppet agent.
Also $facts or $os_family was not available on windows jump host
There was a problem hiding this comment.
The task works fine without facter/puppet. They don't need to be installed. That's why I suggested it.
There was a problem hiding this comment.
I still think this should be addressed before merging.
cathal41
force-pushed
the
PE_38219_windowSupportAirGapInstall
branch
from
754b2fe to
66f40b9
Compare
cathal41
force-pushed
the
PE_38219_windowSupportAirGapInstall
branch
from
3e09bd4 to
bd80892
Compare
…to ps1 files correctly
cathal41
force-pushed
the
PE_38219_windowSupportAirGapInstall
branch
from
5a7561b to
875a8b3
Compare
| @@ -84,7 +84,7 @@ jobs: | |||
| - name: "Run Static & Syntax Tests" | |||
| run: | | |||
| bundle exec rake syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop | |||
| bundle exec dependency-checker metadata.json --override WhatsARanjit/node_manager,0.7.5 | |||
| # bundle exec dependency-checker metadata.json --override WhatsARanjit/node_manager,0.7.5 | |||
There was a problem hiding this comment.
why was this commented out?
|
I don't mind temporary test failures, but https://github.com/puppetlabs/puppetlabs-peadm/pull/438/files#r1639580463 is still an open discussion |
Summary
Adding powershell script files for Filesize, Download and the new os Identifier to allow windows users to preform an air gapped installation
Installer download progress support https://github.com/puppetlabs/installer/pull/481
Checklist
Changes include test coverage?
Have you updated the documentation?