(PE-39397) Adding LDAP endpoint for 2023.8 #515
Merged
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragingra
force-pushed
the
PE-39397
branch
3 times, most recently
from
ddb42a7 to
ffbf6b3
Compare
As rbac-api/v1/ds has been deprecated, and remove in 2023.8, we need to utilise the new endpoint. Adding case for installs of versions 23.8 and above to use rbac-api/v1/command/ldap/create.
davidmalloncares
force-pushed
the
PE-39397
branch
from
9ec287f to
22833fa
Compare
|
As mentioned in #498: please do not go this route. This is only useful when using PEADM and won't help to enforce the LDAP configuration via Puppet. Please instead patch the puppet_ds module and utilize that within PEADM. |
|
I think this is a very pragmatic approach as it just fixes the existing support for LDAP configuration. #498 is requesting an entirely new supported module and then a re-write of |
davidmalloncares
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As rbac-api/v1/ds has been deprecated, and remove in 2023.8, we need to utilise the new endpoint. Adding case for installs of versions 23.8 and above to use rbac-api/v1/command/ldap/create.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
#498
Checklist
Changes include test coverage?
Have you updated the documentation?