Modernize Upgrade Plan #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures the upgrade plan is functional for the peadm module over ssh. The upgrade plan has not been well supported in the past. This commit is a first step and its objective is only base functionality. Additional features such as input validation and orchestrator transport support will need to be added iteratively. As an improvement over the alpha version of this plan, upgrade the PostgreSQL nodes *first*, so that upgrade of the master/replica can proceed without error in the event a major PostgreSQL version is released. Upgrade plan is also annotated with stage separators to make it easier to follow what is going on.
Many of the tasks/plans shipped in PE are brittle and make assumptions about environment variables. By enforcing PATH (and HOME, and USER) in agent_upgrade.sh we hopefully insulate ourselves from the worst of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the upgrade plan work at a base level with the current version of peadm.