Add direct download option for PE installers #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new download_mode parameter to the peadm::provision and peadm::upgrade plans. The default value for the parameter is bolthost, which causes PE installation content to be downloaded to the stagingdir of the workstation running bolt and then uploaded to the PE hosts. Setting download_mode to direct causes PE installation content to be downloaded directly to the PE hosts. The direct mode skips uploads, which offers a significant speed boost when the PE hosts have a route to the internet and the bolt host is connected by a slow link, such as VPN.
|
I validated this on both gcp and aws builds through autope, works well. Investigated travis tests and they are passing, no idea why one of the builds are stuck. Merging. |
ody
reviewed
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new download_mode parameter to the peadm::provision
and peadm::upgrade plans. The default value for the parameter is
bolthost, which causes PE installation content to be downloaded to the
stagingdir of the workstation running bolt and then uploaded to the
PE hosts. Setting download_mode to direct causes PE installation content
to be downloaded directly to the PE hosts. The direct mode skips uploads,
which offers a significant speed boost when the PE hosts have a route to
the internet and the bolt host is connected by a slow link, such as VPN.