Docker updates #98
Merged
Docker updates #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When running puppetdb queries in the container it is helpful to
have the the config file setup already. This commit configures
the puppetdb.conf file on the puppet servers.
* The docker container for bolt was having some encoding issues
after running a plan. This fixes that issue so the plan/command
does not fail.
* Only applies to the example docker containers
* This only applies to our example docker containers.
If the docker host reboots, the containers will now
restart upon reboot. Was just too annoying before to always
have to start up the machines again.
* previously if a puppet 5 agent had already submitted a CSR
the submit_csr task would fail. This fixes that by checking
if the host making the request has a cert already.
Note this does not verify the cert is actually valid but only if the
cert exists or not. In puppet 6 we use ssl verify to do actual
verification.
* Specifies how to start a container so it can use the PE stack.
logicminds
force-pushed
the
docker_updates
branch
from
0470094 to
56c3444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix a a few minor annoyances I have found so far when operating the docker example containers.
I also made some speed enhancements with the sign_csr.rb task so it would just load Puppet and use the settings instead of shelling out multiple times.