(CONT-808) Ruby 3 / Puppet 8 Support #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
CONT-808-ruby_3
branch
from
0efacf1 to
ff97982
Compare
chelnak
force-pushed
the
CONT-808-ruby_3
branch
2 times, most recently
from
7af50b2 to
67d9af1
Compare
ekohl
reviewed
Apr 12, 2023
chelnak
force-pushed
the
CONT-808-ruby_3
branch
2 times, most recently
from
bf3b68d to
4544e7c
Compare
|
@ekohl All valid suggestions here, thank you 😄 . With regards to removal of legacy Puppet code, I think ultimately it's going to come down to time, for me at least. I'd be happy to work through PRs from yourself / other community members though. This is something I've just asked about internally as a way to get rspec-puppet rolling again. |
chelnak
force-pushed
the
CONT-808-ruby_3
branch
from
47f0bed to
79f7f56
Compare
GSPatton
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Ruby3x and Puppet 8