Skip to content

Misuse of 'floaty revert ...' seems to create a new snapshot #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KevinCorcoran opened this issue Sep 16, 2016 · 2 comments
Closed

Misuse of 'floaty revert ...' seems to create a new snapshot #31

KevinCorcoran opened this issue Sep 16, 2016 · 2 comments

Comments

@KevinCorcoran
Copy link 

$ floaty revert bi0jchf23ae429h h35uv4oyam2q0c82p9zbje82oaort6ai
{"ok"=>true,
 "bi0jchf23ae429h"=>{"snapshot"=>"duc00v7h4r7c81lk6ii51yz0staca6o0"}}

It looks like the correct syntax is actually

floaty revert bi0jchf23ae429h --snapshot h35uv4oyam2q0c82p9zbje82oaort6ai

but this mistake should not result in the creation of a new snapshot.
briancain added a commit that referenced this issue Sep 17, 2016
@briancain
(#31) Improve how users can provide arguments to commands
1d0fc42 
Prior this commit, some commands did not accept some options as an
argument and instead only worked through a flag. This commit updates
that behavior to allow users to specify some options through arguments,
while leaving the ability to continue to specify those options through
flags. Command line arguments take precedence over flags. It also fixes
an issue where if a snapshot sha was nil, it would submit a request to
take a snapshot to vmpooler.
@briancain
Copy link
Contributor

@KevinCorcoran thanks for the issue request! Totally a bug 👍 I pushed up a commit which should fix that, as well as improve how vmfloaty handles command line arguments versus flags. I'll cut a release on Monday

@briancain
Copy link
Contributor

This should be released in vmfloaty (0.6.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@briancain @KevinCorcoran