Update rubocop requirement from ~> 0.52 to ~> 1.6 #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.52.0...v1.6.0) Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
requested review from
briancain,
highb and
a team
as code owners
|
@genebean Heads up that there are some major changes in Rubocop 1.0 that might cause issues here. Then again, I don't think Rubocop is run in Travis, and I'm not sure how out of date the rubocop TODO file is so maybe it's no big deal. |
|
A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
sbeaulie
approved these changes
Feb 25, 2021
|
Bringing this in, will open a separate ticket to at least do the auto correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on rubocop to permit the latest version.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
64e8c47Cut 1.6337570fUpdate Changelogfe46341[Fix #9160] Fix an incorrect auto-correct forStyle/SoleNestedConditional1386f77UpdatedLayout/LineLength,Style/CharacterLiteral,Style/IpAddresses, `...8f2fdbeFix cli_autocorrect_spec failures now that #9187 and #9190 are merged.24765a0[Fix #9175] Fix status for offenses that are not correctable.0146f4f[Fix #7801] Update documentation forNaming/AccessorMethodName.ebd90fb[Fix #8897] ChangeStyle/StringConcatenationto accept line-end concatenati...dbd9acaUpdate formatters to output[Correctable]for correctable offenses.3a2786fUpdate reference forStyle/FloatDivisionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)