-
Notifications
You must be signed in to change notification settings - Fork 26
Developersdevelopersdevelopers #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
briancain
merged 7 commits into
puppetlabs:master
from
mckern:developersdevelopersdevelopers
Mar 1, 2017
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
573f0d8
Update Gemspec
mckern 8babbe3
Add Rubocop support to Rakefile
mckern ee0c73d
Add a little formatting to Rspec
mckern 21c42db
Clarify license in Gemspec
mckern 0380b5f
Gemspec whitespace & tighter version constraints
mckern 5c794cd
Use the Classname::VERSION pattern
mckern d7e3bc9
Improve Travis platforms
mckern File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
sudo: false | ||
language: ruby | ||
rvm: | ||
- 2.0.0-p247 | ||
- 2.1 | ||
script: rspec spec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
source 'https://rubygems.org' | ||
|
||
gem 'commander' | ||
gem 'faraday', '0.9.2' | ||
gem 'colorize', '~> 0.8' | ||
gemspec | ||
|
||
gem 'rspec' | ||
gem 'webmock', '1.21.0' | ||
gem 'rake' | ||
gem 'rake', require: false | ||
|
||
gemspec | ||
group :test do | ||
gem 'rspec', '~> 3.5.0' | ||
gem 'rubocop', '~> 0.47' | ||
gem 'webmock', '1.21.0' | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,29 @@ | ||
require 'rubygems' | ||
require 'bundler/setup' | ||
require 'rspec/core/rake_task' | ||
require 'rubocop/rake_task' | ||
|
||
# Immediately sync all stdout so that tools like buildbot can | ||
# immediately load in the output. | ||
$stdout.sync = true | ||
$stderr.sync = true | ||
|
||
# Change to the directory of this file. | ||
Dir.chdir(File.expand_path("../", __FILE__)) | ||
Dir.chdir(File.expand_path('../', __FILE__)) | ||
|
||
# This installs the tasks that help with gem creation and | ||
# publishing. | ||
Bundler::GemHelper.install_tasks | ||
|
||
# Install the `spec` task so that we can run tests. | ||
RSpec::Core::RakeTask.new(:spec) do |t| | ||
t.rspec_opts = "--order defined" | ||
t.rspec_opts = '--order defined' | ||
end | ||
|
||
desc 'Run RuboCop' | ||
RuboCop::RakeTask.new(:rubocop) do |task| | ||
task.options << '--display-cop-names' | ||
end | ||
|
||
# Default task is to run the unit tests | ||
task :default => :spec | ||
task default: :spec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,3 @@ | ||
|
||
class Version | ||
@version = '0.7.8' | ||
|
||
def self.get | ||
@version | ||
end | ||
class Vmfloaty | ||
VERSION = '0.7.8'.freeze | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,8 @@ | ||
require 'vmfloaty' | ||
require 'webmock/rspec' | ||
|
||
RSpec.configure do |config| | ||
config.color = true | ||
config.tty = true | ||
config.formatter = :documentation | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,22 @@ | ||
$LOAD_PATH.push File.expand_path('../lib', __FILE__) | ||
require 'vmfloaty/version' | ||
|
||
Gem::Specification.new do |s| | ||
s.name = 'vmfloaty' | ||
s.version = '0.7.8' | ||
s.version = Vmfloaty::VERSION | ||
s.authors = ['Brian Cain'] | ||
s.email = ['[email protected]'] | ||
s.license = 'Apache' | ||
s.license = 'Apache-2.0' | ||
s.homepage = 'https://github.com/briancain/vmfloaty' | ||
s.description = 'A helper tool for vmpooler to help you stay afloat' | ||
s.summary = 'CLI application to interface with vmpooler' | ||
|
||
s.executables = ['floaty'] | ||
s.files = Dir['LICENSE', 'README.md', 'lib/**/*'] | ||
s.test_files = Dir['spec/**/*'] | ||
s.require_path = 'lib' | ||
s.add_dependency 'commander', '~> 4.3' | ||
s.add_dependency 'faraday', '~> 0.9' | ||
s.add_dependency 'colorize', '0.8.1' | ||
|
||
s.add_dependency 'commander', '~> 4.3.0' | ||
s.add_dependency 'faraday', '~> 0.9.0' | ||
s.add_dependency 'colorize', '~> 0.8.1' | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, haven't tried this yet but I've tried to get this to work this way for a couple of times now and it never seems to behave correctly. 👍