-
Notifications
You must be signed in to change notification settings - Fork 26
(QENG-7604) Add support for Job IDs to ABS delete #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(QENG-7604) Add support for Job IDs to ABS delete #60
Conversation
Here it is working for me:
|
@mikkergimenez Will hopefully do some review on this. |
Looks like rubocop failed.... @highb to be honest I wouldn't care at all if you just removed it from this repo 🤷♂️ It's useful in certain situations but I don't feel like it's worth it for something like this. Up to you all! |
Naw, it's probably good to keep it. Consistent style is important. I'll fix it up. 😆 |
Alright, rubocop seems happy. |
lib/vmfloaty.rb
Outdated
@@ -184,10 +184,12 @@ def run # rubocop:disable Metrics/AbcSize | |||
end | |||
|
|||
command :delete do |c| | |||
c.syntax = 'floaty delete hostname,hostname2 [options]' | |||
c.syntax = 'floaty delete hostname,hostname2 [options] | |||
floaty delete job1,job2 [options] (only supported with ABS)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Futzed around with it a bit and found a better way of adding to the syntax that can be aligned correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @highb - just one minor typo ?
And have just run it through a few tests and appears to work 👍 |
This commit adds support for passing in a JobID when deleting with ABS.
@briancain John and Mikker are 👍 on this, if you don't mind approving/merging it. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This commit adds support for passing in a JobID when deleting with ABS.