Skip to content

Create gempush.yml Github Action #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Create gempush.yml Github Action #64

merged 1 commit into from
Feb 5, 2020

Conversation

highb
Copy link
Contributor

@highb highb commented Feb 5, 2020

I think this action should be able to build/push the gem whenever a matching tag is pushed.

Status

Ready for Merge?

I think this action should be able to build/push the gem whenever a matching is pushed.
@briancain
Copy link
Contributor

Hey @highb - I was thinking something similar. It'd be nice to have an action for this so I'm not just shipping it from my computer 😆 Question: Does this run on every commit to master? Maybe it could be run per tag when a tag gets pushed? Maybe that's how it already will work!

Also, I'm happy to add you to the rubygems page if you wanted to use your API key here. It looks like it already does this, but it would be good to confirm that the API key doesn't accidentally get dumped any where visible 🙏

on:
push:
tags:
- 'v*.*.*'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This restricts the action to only run when a tag matching this glob is pushed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's what I was hoping for. I think that should match the current tag convention we've been using?

@highb
Copy link
Contributor Author

highb commented Feb 5, 2020

@briancain Yeah from reading the GH action docs, I think this means it will only trigger when a matching tag is pushed:

on:
  push:
    tags:
      - 'v*.*.*'

@highb
Copy link
Contributor Author

highb commented Feb 5, 2020

Oh and if you want to add me on Rubygems: https://rubygems.org/profiles/highb

I think the secret should be hidden with GH actions as long as it's saved as a secret and not as a plain ENV variable.

@briancain
Copy link
Contributor

@highb - Looks like I need your rubygems email address to add you, can't do it through the website 😮

@briancain
Copy link
Contributor

@highb - scratch that. Looks like it accepted a rubygems username just fine despite what it claimed to be asking for! 😅 You should be an owner now.

@highb
Copy link
Contributor Author

highb commented Feb 5, 2020

I guess let's merge this and the version bump, I'll plug in the API secrets from my account, then push a tag and 🤞

@highb highb merged commit 7965556 into master Feb 5, 2020
@highb
Copy link
Contributor Author

highb commented Feb 5, 2020

@briancain Hey sorry to bug you again but it seems like the action isn't showing up? Are actions enabled in Settings? https://github.com/briancain/vmfloaty/settings/actions I also think that the only people who get access to the Secrets tab are admins, if I'm reading the docs right https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization

@briancain
Copy link
Contributor

Hey @highb - Yep, they are enabled from what I can see

Screenshot from 2020-02-05 15-16-46

From what I can tell, workflows won't show up or run until there's something to run. We haven't pushed any tags since merge (and looks like I forgot to push the last tag for v0.9.1), so I imagine if we tag and push, the workflow will run? 🤔

Also if you want, you could send me your API key through keybase and I can add it. I can't see a way to give you admin access to this repo, but if that's a possibility I'd be happy to do that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants