Update docs #69
Update docs #69
Conversation
vmfloaty.gemspec
Outdated
| @@ -6,10 +6,10 @@ require 'vmfloaty/version' | |||
| Gem::Specification.new do |s| | |||
| s.name = 'vmfloaty' | |||
| s.version = Vmfloaty::VERSION | |||
| s.authors = ['Brian Cain'] | |||
| s.email = ['[email protected]'] | |||
| s.authors = ['Puppet'] | |||
There was a problem hiding this comment.
Hey! I'd prefer to still be the author here since I wrote it :p Feel free to update the email though to include puppet, but I'd rather not erase the fact that I authored this project 😄
There was a problem hiding this comment.
I agree, Brian wrote this and we should continue to credit him in the gemspec. Please update this to an array with both Brian and Puppet, @genebean.
There was a problem hiding this comment.
I’ll push an update as soon as my internet gets unbusted
There was a problem hiding this comment.
This should be good now
vmfloaty.gemspec
Outdated
| s.authors = ['Brian Cain'] | ||
| s.email = ['brianccain@gmail.com'] | ||
| s.authors = ['Puppet'] | ||
| s.email = ['dio-gems@puppet.com'] |
There was a problem hiding this comment.
| s.email = ['[email protected]'] | |
| s.email = ['[email protected]', '[email protected]'] |
There was a problem hiding this comment.
This should also be good now
This chane updates docs to reflect that ownership has moved to the DIO team at Puppet. It also includes some formatting changes.
|
@briancain & @highb I think I have made all requested changes and then some :) |
|
Aw, nice idea on the "Special Thanks" section. 😄 This looks good to me; @briancain any additional feedback? |
|
Yeah! Looks good to me. Thanks for the special thanks section ❤️ |
This chane updates docs to reflect that ownership has moved to the DIO team at Puppet. It also includes some formatting changes.