Print all non-success output to STDERR #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austb
force-pushed
the
print-debug-to-stderr
branch
from
18e781e to
4755343
Compare
|
Copying from Slack, The motivation behind this is that I have a few scripts that either to get the hostname to run bolt against or |
briancain
suggested changes
Aug 10, 2020
There was a problem hiding this comment.
Hey there 👋 thanks for the updates.
Generally, I think it's good to unify the output for vmfloaty to be consistent when printing messages for success or failure. However I think just putting STDOUT or STDERR in front of puts will make this easy for future contributors to make a mistake and not be explicit. For that reason, I think it would make more sense to add a small message printer class and stop using puts all together (which is kind of an anti-pattern to use just puts for CLI tools anyway, I think).
This adds the Logger class for log output, all of which goes to STDERR, and uses puts to send only the command result to STDOUT.
austb
force-pushed
the
print-debug-to-stderr
branch
from
f6b4dab to
8ec9000
Compare
briancain
suggested changes
Aug 11, 2020
mattkirby
approved these changes
Aug 11, 2020
This moves the instance of the logger class to a class variable in the `FloatyLogger` class and provides three class methods to log with in the rest of the project `FloatyLogger.info`, `FloatyLogger.warn`, and `FloatyLogger.error`.
briancain
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for Review
Description
This tries to move all
putsoutput to STDERR, except if it's the successful output of a command. It was done almost entirely via search and replace so it could use a three-quarter to full-hearted review.Todos
Reviewers
@puppetlabs/dio
@highb
@briancain