Fix the argument list for nonstandardpooler #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, 7 arguments would be sent into the `retrieve` method in nonstandardpooler. There were only 6 arguments in the method definition so an error would be thrown. This commit adds the `ondemand` argument to the `retrieve` method, but does not utilize it.
jarretlavallee
requested review from
briancain,
highb and
a team
as code owners
briancain
suggested changes
Aug 13, 2020
|
@briancain I think that is the same line this PR is for. Was there another place I should be adding this? |
|
Lol oops you're right 🤦 I just did a qiuck search to see if there were any other places that could of been missed 😅 Alright makes sense! 😄 |
briancain
approved these changes
Aug 13, 2020
mattkirby
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following error in 0.10.0 when using
nonstandard_pooler. Theondemandargument was added to the otherretrievemethods but missed innonstandardpoolercausing failures when provisioning.Status
[Ready for Merge]
Description
Related Issues
Todos
Reviewers
@puppetlabs/dio
@highb
@briancain