Skip to content
This repository was archived by the owner on Aug 4, 2023. It is now read-only.

Add rmdir', rm, rm' #39

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Add rmdir', rm, rm' #39

merged 3 commits into from
Jun 10, 2022

Conversation

wclr
Copy link
Contributor

@wclr wclr commented Jun 10, 2022 •
edited
Loading

Description of the change

Adds rmdir, rm, rm'

purescript-node/purescript-node-fs#67

Changes:

  • Update rmdir' to take options arg
  • Added rm and rm' version with and witout options arg

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

JordanMartinez
JordanMartinez approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry here?

@JordanMartinez
Copy link
Contributor

Can you bump the node-fs dep to 8.1.0?

@JordanMartinez JordanMartinez merged commit a844110 into purescript-deprecated:master Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JordanMartinez JordanMartinez JordanMartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wclr @JordanMartinez