Skip to content

Add lyricStreams() convenience method #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 22, 2023
Merged

Add lyricStreams() convenience method #1303

merged 4 commits into from
Dec 22, 2023

Conversation

JonnyWong16
Copy link
Collaborator

Description

  • Moves videoStreams(), audioStreams(), and subtitleStreams() to Playable.
  • Adds matchinglyricStreams() method.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 force-pushed the feature/track_lyricStreams branch from b179452 to 2f597a2 Compare November 19, 2023 20:55
@JonnyWong16 JonnyWong16 mentioned this pull request Nov 21, 2023
Draft
15 tasks
@JonnyWong16 JonnyWong16 merged commit f7522af into pushingkarmaorg:master Dec 22, 2023
@JonnyWong16 JonnyWong16 deleted the feature/track_lyricStreams branch February 4, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonnyWong16