-
Notifications
You must be signed in to change notification settings - Fork 201
feat: Add sonicAdventure method to MusicSection #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
4bc5fe0
ac70d5b
83bfd8b
c096fbb
c1ef6e1
41796ba
8e9c1ec
673b9ed
0091719
690a4a8
f36dc22
7ee036e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -2,6 +2,7 @@ | |||||
from urllib.parse import quote_plus | ||||||
|
||||||
import pytest | ||||||
import plexapi | ||||||
from plexapi.exceptions import BadRequest | ||||||
|
||||||
from . import conftest as utils | ||||||
|
@@ -398,6 +399,14 @@ def test_audio_Track_lyricStreams(track): | |||||
assert not track.lyricStreams() | ||||||
|
||||||
|
||||||
@pytest.mark.authenticated | ||||||
def test_audio_Track_sonicAdventure(music): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do these tests work on the bootstrap test server? It only has one track and we disable all the analysis tasks (although it looks like we forgot to disable sonic analysis). Also needs a Plex Pass account.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it might not, I changed my bootstrap server by adding a few tracks from my collection to test these features There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So this does not work on the bootstrap server with a single track, or even two tracks. The tests fail at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
would return list of 2 tracks, same as the args if not adventure between them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried this on my own server and it returns a blank list. The start and end are not included. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. okay, I would be wrong on this then, however the tests should be okay regardless |
||||||
tracks = music.searchTracks() | ||||||
adventure = tracks[0].sonicAdventure(tracks[-1]) | ||||||
assert len(adventure) | ||||||
assert all(isinstance(t, plexapi.audio.Track) for t in adventure) | ||||||
|
||||||
|
||||||
def test_audio_Track_mixins_images(track): | ||||||
test_mixins.attr_artUrl(track) | ||||||
test_mixins.attr_posterUrl(track) | ||||||
|
Uh oh!
There was an error while loading. Please reload this page.