Use SPDX license identifier #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonnyWong16
reviewed
Jan 9, 2025
| @@ -7,7 +7,7 @@ description = "Python bindings for the Plex API." | |||
| readme = "README.rst" | |||
| requires-python = ">=3.9" | |||
| keywords = ["plex", "api"] | |||
| license = {file = "LICENSE.txt"} | |||
| license = {text = "BSD-3-Clause"} | |||
There was a problem hiding this comment.
Should this just be
Suggested change
| license = {text = "BSD-3-Clause"} | |
| license = "BSD-3-Clause" |
There was a problem hiding this comment.
That's not yet supported by setuptools unfortunately. Using the legacy license.text is the next best thing for the time being.
There is a open PR in setuptools to add full support for it. That one depends on some other (unrelated) work though, so it's still some time until it's added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the SPDX license identifier as recommended by PEP 639.
https://spdx.org/licenses/BSD-3-Clause.html