LGTM has 6 errors

[mikofski]

Describe the bug
LGTM shows 6 errors, at least one seems easy to fix there is a self alignment that seems redundant

To Reproduce
https://lgtm.com/projects/g/pvlib/pvlib-python/alerts/?mode=list&severity=error

Expected behavior
No errors?

Screenshots
https://lgtm.com/projects/g/pvlib/pvlib-python/alerts/?mode=list&severity=error

Versions:

• pvlib.__version__: 0.9ish
• pandas.__version__: ?
• python: 3

Additional context
https://lgtm.com/projects/g/pvlib/pvlib-python/alerts/?mode=list&severity=error

[wholmgren]

Certainly should fix that self assignment. Maybe silence the others?

[mikofski]

I found a Python "LGTM alert suppression" example here: https://lgtm.com/help/lgtm/alert-suppression#python

Altho I think we should try to learn a bit about why LGTM raises these alerts before deciding to silence them. Could be something useful?

[wholmgren]

I've clicked the Hide button on a handful of similar alerts in the past. I didn't know about the comment option until now.

I tried looking into it a few years ago and didn't figure it out. Maybe someone smarter than me can figure it out.

[chrisorner]

I've clicked the Hide button on a handful of similar alerts in the past. I didn't know about the comment option until now.

I tried looking into it a few years ago and didn't figure it out. Maybe someone smarter than me can figure it out.

This is a bug in LGTM. It raises this error because of the user function test in test_modelchain.py:

Where constant_aoi_loss is a Python partial function which is the known bug in LGTM. So this error can be ignored. I am going to take a look at the others as well.

[chrisorner]

I am pretty sure that the alerts under non-callable can be ignored as well:

I described the issue here because I think it's also a bug in LGTM.