Skip to content

DOC: irradiance.dni() not exposed in API, but also not private #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikofski opened this issue Apr 8, 2019 · 1 comment · Fixed by #692
Closed

DOC: irradiance.dni() not exposed in API, but also not private #686

mikofski opened this issue Apr 8, 2019 · 1 comment · Fixed by #692
Labels
bug documentation good first issue help wanted
Milestone
0.6.2

Comments

@mikofski
Copy link
Member

mikofski commented Apr 8, 2019 •
edited
Loading

Describe the bug
there is a nice function in the code called pvlib.irradiance.dni() that makes sure (GHI-DHI)/cos(zenith) isn't bonkers when cos(zenith)->zero, but it's not in the documentation.

Ok it's in one location, here

I think it just needs to be listed in the api.rst page, but where? It's not really a DNI estimation method, because it uses exact values of GHI and DHI, so not sure where it should go
@mikofski
Copy link
Member Author

mikofski commented Apr 8, 2019

@patrickjmathiesen this might be a good first PR for you if you're interested?

@wholmgren wholmgren added this to the 0.6.2 milestone Apr 8, 2019
tahentx added a commit to tahentx/pvlib-python that referenced this issue Apr 24, 2019
@tahentx
add irradiance.dni() function to Decomposing and combining irradiance…
f4af871 
… section of api.rst. this seems to be the most reasonable section to reference the function. Issue pvlib#686.
@tahentx tahentx mentioned this issue Apr 24, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation good first issue help wanted
Projects
None yet
Milestone
0.6.2
Development

Successfully merging a pull request may close this issue.

add irradiance.dni() function to Decomposing and combining irradiance… tahentx/pvlib-python
2 participants
@mikofski @wholmgren