Skip to content

add minimum requirements configuration to azure conda linux #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Jul 17, 2020

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Travis is no longer posting build results to PRs, as discussed in #1003 (comment). We want to move away from Travis anyways (#950), so I don't think it's worth fixing that.

This PR adds the requirements-35-min.yml configuration to the azure build matrix. We're not quite ready to fully deprecate Travis because we use it for deploying tagged versions, but I don't want to tackle that in this quick fix PR.

@kanderso-nrel if you agree with this strategy then I suggest merging now so that we can more confidently address the PR backlog.

@wholmgren wholmgren added this to the 0.8.0 milestone Jul 17, 2020
@wholmgren wholmgren changed the title add suffix to azure conda linux add minimum requirements configuration to azure conda linux Jul 17, 2020
@wholmgren
Copy link
Member Author

Note that the minimum dependencies are installed as expected: https://dev.azure.com/solararbiter/pvlib%20python/_build/results?buildId=3806&view=logs&j=b0b9a916-ca36-5efa-d29b-53c06cc9f57e&t=4ba54437-40a7-57ed-3068-2429b2777782&l=39

Test failures due to the usual external API suspects.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, was just checking through that. This only tests the min configuration on conda linux of course -- fine by me, just pointing it out in case you want to do the same for the other platforms. LGTM

@wholmgren
Copy link
Member Author

This only tests the min configuration on conda linux of course -- fine by me, just pointing it out in case you want to do the same for the other platforms.

I think that will be more doable when fully addressing #950, especially if switching to github actions which has a more uniform specification across platforms.

@wholmgren wholmgren merged commit f6f9207 into pvlib:master Jul 17, 2020
@wholmgren wholmgren deleted the azuremin branch July 17, 2020 16:32
@cwhanse
Copy link
Member

cwhanse commented Jul 17, 2020

OK with me to merge when ready @wholmgren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants