Skip to content

fix for https://github.com/pvlib/pvlib-python/issues/102 #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jan 20, 2016
Merged
Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
8088ee8
fix for https://github.com/pvlib/pvlib-python/issues/102
Nov 25, 2015
ac236e8
moved table & added example for .IEC61724:1998
Jan 18, 2016
284f421
corrected cols
Jan 18, 2016
e6dea98
moving the file the hard way
Jan 18, 2016
15675fd
Merge remote-tracking branch 'refs/remotes/pvlib/master' into doc_var
Jan 19, 2016
73af050
updated IEC symbol to better math
Jan 19, 2016
8bb5be0
included transposition factor
Jan 19, 2016
d83f934
minor correction of table display
Jan 19, 2016
4584636
link correction
Jan 19, 2016
eb16adf
added PVPMC link
Jan 19, 2016
e27f443
corrected list
Jan 19, 2016
59ad15a
list fixing
Jan 19, 2016
ddff859
minor corrections
Jan 19, 2016
fcbd87b
list correction
Jan 19, 2016
f5cb190
list
Jan 19, 2016
ca1ce2d
table tweak
Jan 19, 2016
19a4a2c
list testing
Jan 19, 2016
798796f
endless list check with RTD stylesheet
Jan 19, 2016
10d2572
testing
Jan 19, 2016
95dbf86
test
Jan 19, 2016
5561cff
test tables
Jan 19, 2016
e92b67d
latex math: fraction
Jan 19, 2016
50e9683
underscore
Jan 19, 2016
c231d91
corrected title
Jan 19, 2016
ee35b81
removed test lists
Jan 19, 2016
c80ebeb
fix list
Jan 19, 2016
b9de720
implemented change proposals in
Jan 19, 2016
4173532
coorections acc. https://github.com/pvlib/pvlib-python/pull/103/files…
dacoex Jan 19, 2016
af2f656
corrections as in https://github.com/pvlib/pvlib-python/pull/103/file…
dacoex Jan 19, 2016
c820ee4
corrected file reference
dacoex Jan 19, 2016
c5447f7
typos
dacoex Jan 19, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ coverage.xml


#Datafiles
*.csv
#*.csv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change this.


# vi
*.swp
Expand Down
3 changes: 3 additions & 0 deletions docs/sphinx/source/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ and

The GitHub wiki also has a page on `Projects and publications that use pvlib python <https://github.com/pvlib/pvlib-python/wiki/Projects-and-publications-that-use-pvlib-python>`_ for inspiration and listing of your application.

There is a :ref:`variable naming convention <variables_style_rules>` to ensure consistency throughout the library.

Installation
============

Expand All @@ -60,6 +62,7 @@ Contents
self
whatsnew
comparison_pvlib_matlab
variables_style_rules
pvlib


Expand Down
29 changes: 29 additions & 0 deletions docs/sphinx/source/variables_style_rules.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
.. _variables_style_rules:

Variables and Symbols
=====================

There is a convention on consistent variable names throughout the library:

.. csv-table:: List of used Symbols and Variables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no symbols in this table

:file: ../../../pvlib/data/variables_style-rules.csv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name should just use underscores.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplicity

:delim: ;
:header-rows: 1
:widths: 5, 5
:stub-columns: 1

For an definition and further help on symbols and units refer to the following sources:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to say something about the fact that these references might not use the same terminology as us.



* `Reference Variable List by PVPMC <https://pvpmc.sandia.gov/resources/variable-list/>`_
* `IEC 61724:1998 -- Photovoltaic system performance monitoring - Guidelines for measurement, data exchange and analysis <https://webstore.iec.ch/publication/5733>`_ ; the Indian Standard referencing the global IEC standard is available online: `IS/IEC 61724 (1998) <https://law.resource.org/pub/in/bis/S05/is.iec.61724.1998.pdf>`_
* Explanation of Solar irradiation and solar geometry by `SoDa Service <http://www.soda-pro.com/home>`_

* `Acronyms, Terminology and Units <http://www.soda-pro.com/help/general/acronyms-terminology-and-units>`_
* `Plane orientations and radiation components <http://www.soda-pro.com/help/general/plane-orientations-and-radiation-components>`_
* `Time references <http://www.soda-pro.com/help/general/time-references>`_
* `Units and conversion tool <http://www.soda-is.com/eng/education/units.html>`_
* `Terminology: definitions of the main quantities. <http://www.soda-is.com/eng/education/terminology.html>`_
* `Acronyms in solar radiation <http://www.soda-is.com/eng/education/acronymes.html>`_ (more extensive list)

.. note:: These further references might not use the same terminology as :mod:pvlib. But the physical process referred to is the same.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The :mod: isn't rendering right. I don't think you need it anyways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this note here responds to:

Probably need to say something about the fact that these references might not use the same terminology as us.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need :mod:. We do need the note.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just pushed corrections

38 changes: 38 additions & 0 deletions pvlib/data/variables_style-rules.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
variable;description
tz;timezone
latitude;latitude
longitude;longitude
dni;direct normal irradiance
dni_extra;direct normal irradiance at top of atmosphere (extraterrestrial)
dhi;diffuse horizontal irradiance
ghi;global horizontal irradiance
aoi;angle of incidence
aoi_projection;cos(aoi)
airmass;airmass
airmass_relative;relative airmass
airmass_absolute;absolute airmass
poa_ground_diffuse;in plane ground reflected irradiation
poa_direct;direct/beam irradiation in plane
poa_diffuse;total diffuse irradiation in plane. sum of ground and sky diffuse.
poa_global;global irradiation in plane. sum of diffuse and beam projection.
poa_sky_diffuse;diffuse irradiation in plane from scattered light in the atmosphere (without ground reflected irradiation)
surface_tilt;tilt angle of the surface
surface_azimuth;azimuth angle of the surface
solar_zenith;zenith angle of the sun in degrees
apparent_zenith;refraction-corrected solar zenith angle in degrees
solar_azimuth;azimuth angle of the sun in degrees East of North
temp_cell;temperature of the cell
temp_module;temperature of the module
temp_air;temperature of the air
temp_dew;dewpoint temperature
relative_humidity;relative humidity
v_mp, i_mp, p_mp;module voltage, current, power at the maximum power point
v_oc;open circuit module voltage
i_sc;short circuit module current
i_x, i_xx;Sandia Array Performance Model IV curve parameters
effective_irradiance;effective irradiance
photocurrent;photocurrent
saturation_current;diode saturation current
resistance_series;series resistance
resistance_shunt;shunt resistance
tf;transposition factor, the gain ration of the radiation in inclinded plane to horizontal plane: :math:`\frac{poa\_global}{ghi}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple typos in this line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer transposition_factor to tf.