Skip to content

Replaced array_like with array-like #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Replaced array_like with array-like #1393

wants to merge 1 commit into from

Conversation

ColmBhandal
Copy link

@ColmBhandal ColmBhandal commented Jan 26, 2022

@ColmBhandal
Copy link
Author

@cwhanse I went ahead and did this PR per our conversation on #765.

@cwhanse
Copy link
Member

cwhanse commented Jan 26, 2022

To underscore our commitment to accurate data types in docstrings, I think we need to test this function using np.array input type. It is tested currently only with pd.Series. @ColmBhandal I'm happy to contribute to this PR if that would help.

@cwhanse cwhanse added this to the 0.9.1 milestone Jan 26, 2022
@ColmBhandal
Copy link
Author

@cwhanse Makes sense- the PR is so small that it would at least beef it up a bit anyway. I will attempt to do that over the next few days. If I need help I will ping you. Thanks!

@cwhanse cwhanse mentioned this pull request Mar 14, 2022
14 tasks
@kandersolar kandersolar mentioned this pull request Mar 18, 2022
8 tasks
@kandersolar kandersolar modified the milestones: 0.9.1, 0.9.2 Mar 29, 2022
@ColmBhandal
Copy link
Author

Based on the associated issue, gonna close this as it's been hanging stale for a while.

@ColmBhandal ColmBhandal closed this Apr 1, 2022
@ColmBhandal ColmBhandal deleted the array-like-typo-fit-sandia branch April 1, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Underscore to Dash in "array_like" for fit_sandia
3 participants