-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Issue#144-fixed the azimuth calculation of rotated PV panel #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixing pvlib#140 by changing the start power (Pso) comparison to use the DC input power (p_dc) instead of the calculated AC power (ac_power).
Testing for issue pvlib#140.
Added note and contribution for fix to issue pvlib#140.
Improved the night tare issue description.
Added carriage returns for improved readability.
…he results are consistent with PVsyst. Also the tests are updated to cover that issue
…he results are consistent with PVsyst. Also the tests are updated to cover that issue
Thanks. I'll make a few line comments. Do you want to rerun the tracking tutorial and commit the results? I can also do this after the merge. |
system.backtrack = False | ||
system.max_angle = 60. | ||
system.axis_tilt = pvsyst_axis_tilt | ||
system.axis_azimuth = 180+pvsyst_axis_azimuth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be more clear what's actually being tested if you make these assignments when the object is created.
Resolve pvlib#140 snlinverter night tare power issue
Please also rebase your changes on the new master, add a note to the bug fix section of the 0.3.1 whatsnew file, and add your name or username to the contributors section of the whatsnew file. |
…e the consistency with PVsyst results. move the comment line up to reduce the line length
I have followed most of your comments. However, I would love more clarifications on "Please also rebase your changes on the new master" |
I merged #141 after you forked pvlib. The
Then resolve the conflict in whatsnew and commit the results. You'll need to add the |
Conflicts: docs/sphinx/source/whatsnew/v0.3.1.txt
I have addressed all your comments. Please double check and merge back at your convenience. |
I checked out @mayudong's branch and reran the And here's the same figure from the v0.3.0 version I should have realized that this behavior wasn't right when I first wrote the code. Thanks for catching it. I'll push the new tutorial next. Closes #144 |
The results are consistent with PVsyst.
Also the tests are updated to cover this issue