Skip to content

Issue#144-fixed the azimuth calculation of rotated PV panel #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 13, 2016

Conversation

mayudong
Copy link
Contributor

The results are consistent with PVsyst.

Also the tests are updated to cover this issue

ejmiller2 and others added 7 commits March 22, 2016 18:09
Fixing pvlib#140 by changing the start power (Pso) comparison to use the DC input power (p_dc) instead of the calculated AC power (ac_power).
Added note and contribution for fix to issue pvlib#140.
Improved the night tare issue description.
Added carriage returns for improved readability.
…he results are consistent with PVsyst.

Also the tests are updated to cover that issue
…he results are consistent with PVsyst.

Also the tests are updated to cover that issue
@wholmgren
Copy link
Member

Thanks. I'll make a few line comments.

Do you want to rerun the tracking tutorial and commit the results? I can also do this after the merge.

system.backtrack = False
system.max_angle = 60.
system.axis_tilt = pvsyst_axis_tilt
system.axis_azimuth = 180+pvsyst_axis_azimuth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be more clear what's actually being tested if you make these assignments when the object is created.

Resolve pvlib#140 snlinverter night tare power issue
@wholmgren
Copy link
Member

Please also rebase your changes on the new master, add a note to the bug fix section of the 0.3.1 whatsnew file, and add your name or username to the contributors section of the whatsnew file.

@wholmgren wholmgren added the bug label Apr 12, 2016
@wholmgren wholmgren added this to the 0.3.1 milestone Apr 12, 2016
@mayudong
Copy link
Contributor Author

I have followed most of your comments. However, I would love more clarifications on "Please also rebase your changes on the new master"
Best

@wholmgren
Copy link
Member

I merged #141 after you forked pvlib. The git rebase command will reapply your new commits on top of the latest version of pvlib. You will need to run something along the lines of

git remote add upstream https://github.com/mayudong/pvlib-python.git
git fetch upstream
git rebase upstream/master

Then resolve the conflict in whatsnew and commit the results. You'll need to add the -f flag to git push to force push the changes to your github branch. Give this a try but if it's too much hassle then I can manually resolve the conflict.

Conflicts:
	docs/sphinx/source/whatsnew/v0.3.1.txt
@mayudong
Copy link
Contributor Author

I have addressed all your comments. Please double check and merge back at your convenience.
Best
Yudong

@wholmgren
Copy link
Member

I checked out @mayudong's branch and reran the tracking tutorial. Here's the new figure that shows the tracking parameters for different surface tilts

tracker fixes

And here's the same figure from the v0.3.0 version

v0 3 0 tracker

I should have realized that this behavior wasn't right when I first wrote the code. Thanks for catching it. I'll push the new tutorial next.

Closes #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants