Skip to content

Removing the 'closed' kwarg from pd.date_range in gallery examples #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/examples/solar-position/plot_sunpath_diagrams.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
tz = 'Asia/Calcutta'
lat, lon = 28.6, 77.2

times = pd.date_range('2019-01-01 00:00:00', '2020-01-01', closed='left',
freq='H', tz=tz)
times = pd.date_range('2019-01-01 00:00:00', '2020-01-01', freq='H', tz=tz)
solpos = solarposition.get_solarposition(times, lat, lon)
# remove nighttime
solpos = solpos.loc[solpos['apparent_elevation'] > 0, :]
Expand Down
2 changes: 1 addition & 1 deletion docs/examples/solar-tracking/plot_single_axis_tracking.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
tz = 'US/Eastern'
lat, lon = 40, -80

times = pd.date_range('2019-01-01', '2019-01-02', closed='left', freq='5min',
times = pd.date_range('2019-01-01', '2019-01-02', freq='5min',
tz=tz)
solpos = solarposition.get_solarposition(times, lat, lon)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,7 @@
gcr = 0.4

# calculate the solar position
times = pd.date_range('2019-01-01 06:00', '2019-01-01 18:00', closed='left',
freq='1min', tz=tz)
times = pd.date_range('2019-01-01 06:00', '2019-01-01 18:00', freq='1min',tz=tz)
solpos = solarposition.get_solarposition(times, lat, lon)

# compare the backtracking angle at various terrain slopes
Expand Down
4 changes: 2 additions & 2 deletions docs/sphinx/source/whatsnew/v0.9.3.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ v0.9.3 (TBD)

Deprecations
~~~~~~~~~~~~

it was removed the tag *close* in the examples files, since it was unsual and it is deprecated for pandas >= 1.4.0.

Enhancements
~~~~~~~~~~~~
Expand Down Expand Up @@ -33,4 +33,4 @@ Requirements

Contributors
~~~~~~~~~~~~

João Guilherme