-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Implement iam.schlick, iam.schlick_diffuse #1562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
4911f16
initial code from Yu Xie
kandersolar d2c0758
edits for pvlib style
kandersolar bd0563a
API and whatsnew entries
kandersolar 82ef3bb
tests
kandersolar f89cfb0
add a comment
kandersolar dfee454
add notes section
kandersolar 51b5f01
Apply suggestions from code review
kandersolar ecebb05
other changes from review
kandersolar 9644569
add iam.schlick
kandersolar 5aa17b5
revise iam.fedis
kandersolar d35d57d
edits
kandersolar 920305a
Update pv_modeling.rst
kandersolar bb7276e
clean up
kandersolar c1bbf35
better default behavior for n_ref
kandersolar b7704c3
Apply suggestions from code review
kandersolar 5d22460
split up schlick/schlick_diffuse/fedis/fedis_diffuse
kandersolar 70ac60c
Apply suggestions from code review
kandersolar 948c8b3
follow up
kandersolar deded0d
use iam.physical in iam.fedis
kandersolar ebcf1f6
Apply suggestions from code review
kandersolar a7d4196
better comments, variable name
kandersolar 4131bcf
Merge remote-tracking branch 'upstream/master' into iam.fedis
kandersolar 1e3b886
revise docstrings
kandersolar 78085c3
Merge remote-tracking branch 'upstream/master' into iam.fedis
kandersolar ae1fa18
clean up 0.9.4 whatsnew, include in whatsnew index
kandersolar c6f4a3c
fix typo
kandersolar 65aad1c
Merge remote-tracking branch 'upstream/main' into iam.fedis
kandersolar 0c87df5
Apply suggestions from code review
kandersolar 4f3afed
Merge branch 'iam.fedis' of github.com:kanderso-nrel/pvlib-python int…
kandersolar db27aa1
stickler
kandersolar a6ec2d0
fix missed variable rename
kandersolar 39a28e2
remove fedis functions
kandersolar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.