Fix CI ASV check by allowing any py 3.9.* for ubuntu-latest #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable 👍 |
|
Thanks for looking into that! |
|
Predicting no objections to what I think is a trivial change, I'll go ahead and merge this so other folks can get rid of the red X on their PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The "quick ASV check" CI job started failing yesterday: https://github.com/pvlib/pvlib-python/actions/runs/3597286595/jobs/6058885668
The job runs on
ubuntu-latest, which as of yesterday refers to Ubuntu-22.04 instead of Ubuntu-20.04 (ref). The oldest patch version of python 3.9 available throughsetup-pythonfor Ubuntu 22.04 is 3.9.12 (actions/setup-python#552 (comment)), so specifying 3.9.7 as the job currently does results in an error. I don't think the patch version really matters here, so I've unpinned the patch version to just require any3.9instead of specifically3.9.7.