Skip to content

Remove pvlib.forecast #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pytest-remote-data.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
SOLARANYWHERE_API_KEY: ${{ secrets.SOLARANYWHERE_API_KEY }}
BSRN_FTP_USERNAME: ${{ secrets.BSRN_FTP_USERNAME }}
BSRN_FTP_PASSWORD: ${{ secrets.BSRN_FTP_PASSWORD }}
run: pytest pvlib/tests/iotools pvlib/tests/test_forecast.py --cov=./ --cov-report=xml --remote-data
run: pytest pvlib/tests/iotools --cov=./ --cov-report=xml --remote-data

- name: Upload coverage to Codecov
if: matrix.python-version == 3.7 && matrix.suffix == ''
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ jobs:
- name: Run tests
shell: bash -l {0} # necessary for conda env to be active
run: |
# ignore iotools & forecast; those tests are run in a separate workflow
pytest pvlib --cov=./ --cov-report=xml --ignore=pvlib/tests/iotools --ignore=pvlib/tests/test_forecast.py
# ignore iotools; those tests are run in a separate workflow
pytest pvlib --cov=./ --cov-report=xml --ignore=pvlib/tests/iotools

- name: Upload coverage to Codecov
if: matrix.python-version == 3.7 && matrix.suffix == '' && matrix.os == 'ubuntu-latest' && matrix.environment-type == 'conda'
Expand Down
1 change: 0 additions & 1 deletion ci/requirements-py3.10.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ dependencies:
- cython
- ephem
- h5py
- netcdf4
- numba
- numpy >= 1.16.0
- pandas >= 0.25.0
Expand Down
1 change: 0 additions & 1 deletion ci/requirements-py3.11.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ dependencies:
- cython
- ephem
- h5py
- netcdf4
- numba
- numpy >= 1.16.0
- pandas >= 0.25.0
Expand Down
2 changes: 0 additions & 2 deletions ci/requirements-py3.7.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ dependencies:
- cython
- ephem
- h5py
- netcdf4
- numba
- numpy >= 1.16.0
- pandas >= 0.25.0
Expand All @@ -23,7 +22,6 @@ dependencies:
- pytz
- requests
- scipy >= 1.4.0
- siphon # conda-forge
- statsmodels
- pip:
- nrel-pysam>=2.0
Expand Down
2 changes: 0 additions & 2 deletions ci/requirements-py3.8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ dependencies:
- cython
- ephem
- h5py
- netcdf4
- numba
- numpy >= 1.16.0
- pandas >= 0.25.0
Expand All @@ -23,7 +22,6 @@ dependencies:
- pytz
- requests
- scipy >= 1.4.0
- siphon # conda-forge
- statsmodels
- pip:
- nrel-pysam>=2.0
Expand Down
1 change: 0 additions & 1 deletion ci/requirements-py3.9.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ dependencies:
- cython
- ephem
- h5py
- netcdf4
- numba
- numpy >= 1.16.0
- pandas >= 0.25.0
Expand Down
8 changes: 1 addition & 7 deletions codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ codecov:
require_ci_to_pass: no

# "flags" are used to identify subsets of the overall codebase when calculating coverage.
# Currently used for "remote_data" (pvlib.iotools & forecast) and "core" (everything else).
# Currently used for "remote_data" (pvlib.iotools) and "core" (everything else).
# Because we only run the remote_data tests sometimes, we need to split it out so that
# codecov doesn't report a big drop in coverage when we don't run them.
# We also use "carryforward: true" so that, when we don't run remote_data tests, the last
Expand All @@ -16,16 +16,12 @@ flags:
- pvlib/
- '!pvlib/iotools/'
- '!pvlib/tests/iotools/'
- '!pvlib/forecast.py'
- '!pvlib/tests/test_forecast.py'
carryforward: false

remote-data:
paths:
- pvlib/iotools/
- pvlib/tests/iotools
- pvlib/forecast.py
- pvlib/tests/test_forecast.py
carryforward: true # if not run, use coverage from previous commit


Expand Down Expand Up @@ -53,15 +49,13 @@ coverage:
paths:
- 'pvlib/tests/.*'
- '!pvlib/tests/iotools/.*'
- '!pvlib/tests/test_forecast.py'
flags:
- core

tests-remote-data:
target: 95%
paths:
- 'pvlib/tests/iotools/.*'
- 'pvlib/tests/test_forecast.py'
flags:
- remote-data

Expand Down
63 changes: 0 additions & 63 deletions docs/sphinx/source/reference/forecasting.rst

This file was deleted.

1 change: 0 additions & 1 deletion docs/sphinx/source/reference/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ API reference
effects_on_pv_system_output/index
tracking
iotools
forecasting
modelchain
bifacial
scaling
Expand Down
Loading