-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add a forecast module #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
change model names
I rewrote much of the cloud cover to irradiance code to
Once again, readthedocs is struggling to build the documentation, so I'm hosting it here. In particular, see the Cloud cover and radiation section for more details on the new algorithm and API. I also merged all of the recent changes to pvlib into this branch and made the tests more robust. |
I have the documentation partly working on readthedocs, in that it works except for the code on the forecast doc page. There's an issue with the conda package installations on rtd that prevents me from adding the dependencies needed for the documentation's forecast code to actually run. I can't reproduce it locally, but these problems fix themselves sooner or later. I added a note about this to the forecast page. So, I think we should call it good enough for now and not let it hold up merging this. I'm planning to merge this and release later today. |
Hi @wholmgren, I'm not sure this is the appropriate place but I just noticed that, when installing pvlib through conda, the forecast module is not immediately available. When doing I'm quite sure this is the intended behavior (not adding heavy dependencies to pvlib by default), but I haven't found this information anywhere (besides the source code, of course). By the way, it is awesome to have an open-source forecasting tool, and it's great to have it integrated in pvlib. Thanks! |
Thanks. This is the intended behavior and is partially documented in the
installation section of the documentation. We’d welcome pull requests to
clarify the installation or forecast documentation. Check out our conda
forge repo for the issues with packaging siphon in the conda distribution.
Welcome help on that too.
…On Tue, Oct 16, 2018 at 3:12 AM GiorgioBalestrieri ***@***.***> wrote:
Hi @wholmgren <https://github.com/wholmgren>, I'm not sure this is the
appropriate place but I just noticed that, when installing pvlib through
conda, the forecast module is not immediately available.
When doing import pvlib it does not seem to contain the forecast module.
Doing from pvlib import forecast throws an error because netcdf4 and
siphon are not installed.
Once these packages have been installed, it is possible to import the
forecast module through from pvlib import forecast, which throws a
warning due to the experimental nature of the module.
I'm quite sure this is the intended behavior (not adding heavy
dependencies to pvlib by default), but I haven't found this information
anywhere (besides the source code, of course).
By the way, it is awesome to have an open-source forecasting tool, and
it's great to have it integrated in pvlib. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#180 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AELiR5abtxABRjH6rwCo3NMdpNf5s3lfks5ulaMXgaJpZM4IkFhB>
.
|
This PR implements a handful of classes that make it easy to access weather forecast data and convert it into a PV power forecast. The weather forecast data comes from U.S. national weather models via Unidata's THREDDS server and Siphon package.
The classes live in a new
forecast.py
module. Unlike the rest of the pvlib modules,forecast.py
must be manually imported since it requires additional dependencies (netcdf and siphon).See the documentation for details:
http://pvlib-python.readthedocs.io/en/forecast/forecasts.html
I see a number of ways this can proceed:
io
ordatareader
subpackage withinpvlib
that containsforecast.py
,tmy.py
, and eventually other users' contributions.pvlib-io
orpvlib-datareader
package that containsforecast.py
andtmy.py
, and eventually other users' contributions.pvlib-forecast
package that containsforecast.py
and leavestmy.py
where it is.I think there are roughly equal pros and cons for all of these approaches and I don't care much between them at this point. Most of these ideas were first discussed in #124.
Finally, this PR is a repeat of #124 but from
pvlib/forecast
topvlib/master
, rather than from my fork topvlib/master
. I hope putting the code on a branch of the pvlib repository makes it slightly easier for people to access the code and try it out. Please comment in #178 if you have opinions on if we should or should not use development branches and PRs like this.