Skip to content

remove skip decorators for linux+python3 and pandas 0.18.0 #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2016
Merged

remove skip decorators for linux+python3 and pandas 0.18.0 #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc61212
remove scipy skip on py3 for conda
wholmgren May 27, 2016
d5f76c5
add notes about skip tests and compatibility
wholmgren May 27, 2016
6d4acac
remove pandas 0180 test entirely
wholmgren May 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions docs/sphinx/source/installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,29 +224,15 @@ Compatibility
pvlib-python is compatible with Python versions 2.7, 3.4, 3.5 and Pandas
versions 0.13.1 or newer.

There are several problems with Continuum's Anaconda packages that may
impact pvlib users.

For Linux + Python 3 users: Continuum's Python 3.x SciPy conda packages
have a few bugs related to complex arithmetic. The most common place for
these bugs to show up when using pvlib-python is in calculating IV curve
parameters using the ``singlediode`` function. We reported `the
issue <https://github.com/ContinuumIO/anaconda-issues/issues/425>`_ to
Continuum and are waiting for it to be fixed. In the meantime, you can
compile your own SciPy distribution, or you can use this hack on Python
3.3 and 3.4 (not 3.5): Downgrade your NumPy to 1.8 and SciPy to 0.14,
then install whatever version of pandas you want but without
dependencies. The conda commands for this are:

``conda install numpy=1.8 scipy=0.14``

``conda install pandas --no-deps``

For Windows + Python 2.7 users: Continuum's Python 2.7 SciPy 0.16.1,
0.17.0, 0.17.1 packages are not compiled properly and will crash your
Python interpreter if you use our Linke turbidity lookup function. See
`Anaconda issue 650
<https://github.com/ContinuumIO/anaconda-issues/issues/650>`_ for more.
There have been several problems with Continuum's Anaconda packages that
have impacted pvlib users. The current problems that we're aware of are
listed below:

#. For Windows + Python 2.7 users: Continuum's Python 2.7 SciPy 0.16.1,
0.17.0, 0.17.1 packages are not compiled properly and will crash your
Python interpreter if you use our Linke turbidity lookup function. See
`Anaconda issue 650
<https://github.com/ContinuumIO/anaconda-issues/issues/650>`_ for more.

Note that our Numba-accelerated solar position algorithms have more
specific version requirements that will be resolved by the Numba
Expand Down
7 changes: 7 additions & 0 deletions docs/sphinx/source/whatsnew/v0.3.3.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ Documentation
(:issue:`182`)


Other
~~~~~

* Removed test skip decorator functions for Linux + Python 3 and for
pandas 0.18.0. (:issue:`187`)


Contributors
~~~~~~~~~~~~

Expand Down
15 changes: 0 additions & 15 deletions pvlib/test/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,6 @@ def incompatible_conda_linux_py3(test):
return out


def incompatible_pandas_0180(test):
"""
Test won't work on pandas 0.18.0 due to pandas/numpy issue with
np.round.
"""

if pd.__version__ == '0.18.0':
out = unittest.skip(
'error on pandas 0.18.0 due to pandas/numpy round')(test)
else:
out = test

return out


def incompatible_pandas_0131(test):
"""
Test won't work on pandas 0.18.0 due to pandas/numpy issue with
Expand Down
7 changes: 0 additions & 7 deletions pvlib/test/test_pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

from nose.tools import assert_equals, assert_almost_equals
from pandas.util.testing import assert_series_equal, assert_frame_equal
from . import incompatible_conda_linux_py3, incompatible_pandas_0180

from pvlib import tmy
from pvlib import pvsystem
Expand Down Expand Up @@ -189,7 +188,6 @@ def test_PVSystem_sapm():
assert_frame_equal(sapm, expected)


@incompatible_pandas_0180
def test_calcparams_desoto():
module = 'Example_Module'
module_parameters = sam_data['cecmod'][module]
Expand All @@ -211,7 +209,6 @@ def test_calcparams_desoto():
assert_almost_equals(nNsVth, 0.473)


@incompatible_pandas_0180
def test_PVSystem_calcparams_desoto():
module = 'Example_Module'
module_parameters = sam_data['cecmod'][module].copy()
Expand All @@ -232,13 +229,11 @@ def test_PVSystem_calcparams_desoto():
assert_almost_equals(nNsVth, 0.473)


@incompatible_conda_linux_py3
def test_i_from_v():
output = pvsystem.i_from_v(20, .1, .5, 40, 6e-7, 7)
assert_almost_equals(-299.746389916, output, 5)


@incompatible_conda_linux_py3
def test_PVSystem_i_from_v():
module = 'Example_Module'
module_parameters = sam_data['cecmod'][module]
Expand All @@ -264,7 +259,6 @@ def test_singlediode_series():
assert isinstance(out, pd.DataFrame)


@incompatible_conda_linux_py3
def test_singlediode_floats():
module = 'Example_Module'
module_parameters = sam_data['cecmod'][module]
Expand All @@ -281,7 +275,6 @@ def test_singlediode_floats():
assert_almost_equals(expected[k], v, 5)


@incompatible_conda_linux_py3
def test_PVSystem_singlediode_floats():
module = 'Example_Module'
module_parameters = sam_data['cecmod'][module]
Expand Down