Skip to content

Fix plotting in plot_singlediode.py gallery page #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Fix plotting in plot_singlediode.py gallery page #1895

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea5cf74
Update plot_singlediode.py
williamhobbs Oct 20, 2023
1c8a589
Update whatsnew.rst
williamhobbs Oct 20, 2023
a5774b5
Update v0.10.3.rst
williamhobbs Oct 23, 2023
d8fd191
Update docs/sphinx/source/whatsnew.rst
williamhobbs Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/examples/iv-modeling/plot_singlediode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@
plt.xlabel('Module voltage [V]')
plt.ylabel('Module current [A]')
plt.title(parameters['Name'])
plt.show()
plt.gcf().set_tight_layout(True)


Expand All @@ -136,6 +135,7 @@ def draw_arrow(ax, label, x0, y0, rotation, size, direction):
ax = plt.gca()
draw_arrow(ax, 'Irradiance', 20, 2.5, 90, 15, 'r')
draw_arrow(ax, 'Temperature', 35, 1, 0, 15, 'l')
plt.show()

print(pd.DataFrame({
'i_sc': curve_info['i_sc'],
Expand Down
8 changes: 8 additions & 0 deletions docs/sphinx/source/whatsnew.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ What's New

These are new features and improvements of note in each release.

Bug fixes
~~~~~~~~~
* Fixed a plotting issue in the IV curve gallery example (:pull:`1895`)

Contributors
~~~~~~~~~~~~
* Will Hobbs (:ghuser:`williamhobbs`)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move these changes to v0.10.3.rst? whatsnew.rst is just an index for the files for each release; it doesn't house any actual content itself.

Also, I think this item should be under Documentation instead of Bug fixes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I updated v0.10.3.rst.

Basic GitHub question: how do I roll back changes to whatsnew.rst?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're using GitHub's web interface to make commits? I don't use it myself but I assume it's possible to edit that file and create a new commit that removes those lines, in much the same way it created a commit to add them.

Another option is to suggest a change to delete those lines and then accept it here in the PR itself.

The most general method is to use a local git client and your own text editor, but that's a bit more involved than clicking a few buttons here on github :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah, I'm using the web interface. I need to get familiar with git...

.. include:: whatsnew/v0.10.2.rst
.. include:: whatsnew/v0.10.1.rst
.. include:: whatsnew/v0.10.0.rst
Expand Down