Skip to content

changed colorbar for plots in plot_sunpath_diagrams.py #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

PhilBrk8
Copy link
Contributor

The scale for the colorbar was numerical from 0-365. The monthly scale in Short month names is much more intuitive for me.

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The scale for the colorbar was numerical from 0-365.
The monthly scale in Short month names is much more intuitive for me.
@kandersolar kandersolar added this to the v0.10.5 milestone Mar 23, 2024
@kandersolar
Copy link
Member

Thanks @PhilBrk8 for the PR! The docs build shows something wrong with the second plot on that page, can you take a look? The linter issues (line length) will also need to be addressed.

addressed linter-issues (line length)
@kandersolar
Copy link
Member

Closing as redundant after #2097

Thanks @PhilBrk8 for highlighting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants