Skip to content

NREL mismatch loss addendum #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 92 commits into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
9c68605
Preliminar implementation, tests, docs and gallery example
echedey-ls Apr 26, 2024
7c17712
Merge branch 'main' into nrel-mismatch-loss
echedey-ls May 6, 2024
23320db
Update versionadded
echedey-ls May 10, 2024
47fa80d
Add example
echedey-ls May 10, 2024
84346d2
docstring update
echedey-ls May 10, 2024
bdb9955
Update v0.11.0.rst
echedey-ls May 10, 2024
914d009
who would have guessed it's always the linter?
echedey-ls May 10, 2024
29f4c66
Update plot_irradiance_nonuniformity_loss.py
echedey-ls May 10, 2024
03011d3
equation fixes
echedey-ls May 10, 2024
de1744a
RMAD properties application typo
echedey-ls May 10, 2024
7f27c9f
does this fix the link?
echedey-ls May 10, 2024
2cdc95f
yet another link
echedey-ls May 10, 2024
0698839
These links will never work, I suppose
echedey-ls May 10, 2024
7f27f1c
Move some "Notes" equations to example and rearrange things there
echedey-ls May 11, 2024
58c05bd
give this equation it's space
echedey-ls May 11, 2024
b973959
eq rendering fixes?
echedey-ls May 11, 2024
448b647
maths are not mathing today
echedey-ls May 11, 2024
5768473
???
echedey-ls May 11, 2024
b1a7e4a
??? x2
echedey-ls May 11, 2024
d1b476d
??? x3
echedey-ls May 11, 2024
d037314
i feel stupid for this
echedey-ls May 11, 2024
4ec952b
Change preprint ref to published one
echedey-ls May 14, 2024
b0cadb5
Published paper coeffs
echedey-ls May 18, 2024
9f51b68
Lots of improvements
echedey-ls May 19, 2024
67d3737
Linter - also missing Eq (7)
echedey-ls May 19, 2024
10ac204
Test polynomial input
echedey-ls May 19, 2024
9290f41
Math
echedey-ls May 20, 2024
c7b94a0
Test exception
echedey-ls May 20, 2024
3599991
Update pvsystem.py
echedey-ls May 20, 2024
c965225
Update plot_irradiance_nonuniformity_loss.py
echedey-ls May 20, 2024
0c15443
Add fill factor ratio
echedey-ls May 20, 2024
d141189
ª
echedey-ls May 20, 2024
8a19a4d
Trying new things
echedey-ls May 21, 2024
c32f78a
Revert "Trying new things"
echedey-ls May 21, 2024
5f69b6d
Update pvsystem.py
echedey-ls May 21, 2024
4c354ea
:(
echedey-ls May 21, 2024
a2de166
:((
echedey-ls May 21, 2024
b572f45
I hope we dont miss that reference
echedey-ls May 22, 2024
1b0565b
Update pvsystem.py
echedey-ls May 22, 2024
87f46f0
Remove second section of the example
echedey-ls May 27, 2024
ae775ec
Minor text upgrade
echedey-ls May 27, 2024
4c75534
Merge branch 'main' into nrel-mismatch-loss
echedey-ls May 27, 2024
1906e20
Update pvsystem.py
echedey-ls May 27, 2024
f5863ce
Port to namespace `pvlib.bifacial`
echedey-ls May 28, 2024
a7d3f7e
Rename to ``power_mismatch_deline``, document in ``bifacial.rst``
echedey-ls May 28, 2024
84f702f
fillfactor only for predefined models
echedey-ls May 28, 2024
3ad18a6
Docstring rewording
echedey-ls May 28, 2024
b6c6fb2
Linter
echedey-ls May 28, 2024
18a397f
More docs rewording
echedey-ls May 28, 2024
1d7d86c
Merge branch 'main' into nrel-mismatch-loss
echedey-ls Jun 11, 2024
8bae370
Apply suggestions from Dax
echedey-ls Jun 12, 2024
75ae58b
Unneded image Dominguez_et_al_PVSC2023.png
echedey-ls Jun 12, 2024
b106ff8
Rename file
echedey-ls Jun 12, 2024
4c78987
Fix equations
echedey-ls Jun 12, 2024
56c7d2e
yup it didnt save
echedey-ls Jun 12, 2024
d225a6d
lintaaaaaaarrrr
echedey-ls Jun 12, 2024
36f3be0
Eq 7 numbering
echedey-ls Jun 12, 2024
0c99269
Revert unintended changes
echedey-ls Jun 12, 2024
a46245a
Adam code review
echedey-ls Jun 12, 2024
a4a32e0
Links?
echedey-ls Jun 12, 2024
88273ba
Referencing equations manually
echedey-ls Jun 12, 2024
f096a0a
Polynomial links
echedey-ls Jun 12, 2024
5945b74
Dont abuse math mode
echedey-ls Jun 12, 2024
adbcbeb
Update loss_models.py
echedey-ls Jun 12, 2024
6f5c69f
I forgot
echedey-ls Jun 12, 2024
770b4a5
Adam Code Review
echedey-ls Jun 12, 2024
329312a
Merge branch 'main' into nrel-mismatch-loss
echedey-ls Jun 20, 2024
9d0411b
Merge branch 'main' into nrel-mismatch-loss
echedey-ls Jun 21, 2024
a9d507f
whatsnews
echedey-ls Jun 21, 2024
243de31
Update v0.11.0.rst
echedey-ls Jun 21, 2024
204f8b7
Weird that some tests pass and others dont
echedey-ls Jun 21, 2024
a88cb4c
Update loss_models.py
echedey-ls Jun 21, 2024
0136b3a
document
echedey-ls Jun 21, 2024
c6ca308
Update loss_models.py
echedey-ls Jun 21, 2024
adad0c1
Kevin's review (I)
echedey-ls Jun 27, 2024
6fafcb4
Kevin's review (II)
echedey-ls Jun 27, 2024
436b0e2
Kevin's review (III)
echedey-ls Jun 28, 2024
7d91db6
Update v0.11.1.rst
echedey-ls Jun 28, 2024
b1b51bd
minor changes
echedey-ls Jun 28, 2024
3991800
Forgot to update tests
echedey-ls Jun 28, 2024
aeaabb4
Accordingly modify model, IO, docs to unitless model
echedey-ls Jun 28, 2024
9289412
Update loss_models.py
echedey-ls Jun 28, 2024
f025133
Update loss_models.py
echedey-ls Jun 28, 2024
69a5acf
Apply suggestions from code review
echedey-ls Jun 30, 2024
945d61a
Code review from Cliff
echedey-ls Jun 30, 2024
cecc337
Rendering issues, code review from Kevin
echedey-ls Jul 1, 2024
289dbeb
Little missing newline
echedey-ls Jul 1, 2024
33ef81c
RMAD func definition addendum
echedey-ls Jul 29, 2024
1e8e9e4
Update v0.11.1.rst
echedey-ls Jul 29, 2024
4953a3f
Merge branch 'main' into nrel-mismatch-loss
echedey-ls Jul 29, 2024
aa8a830
Add RMAD eq to docstring
echedey-ls Jul 30, 2024
6b388d0
Cliff suggestion
echedey-ls Aug 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions docs/examples/bifacial/plot_irradiance_nonuniformity_loss.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,12 @@
#


def rmad(data, axis=None):
def rmad(data):
"""
Relative Mean Absolute Difference. Output is [Unitless].
https://stackoverflow.com/a/19472336/19371110
Relative Mean Absolute Difference. Output is [Unitless]. Eq. (4) of [1]_.
"""
mean = np.mean(data, axis)
mad = np.mean(np.absolute(data - mean), axis)
mean = np.mean(data)
mad = np.mean(np.absolute(np.subtract.outer(data, data)))
return mad / mean


Expand Down
2 changes: 2 additions & 0 deletions docs/sphinx/source/whatsnew/v0.11.1.rst
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ Requirements

Contributors
~~~~~~~~~~~~
* Echedey Luis (:ghuser:`echedey-ls`)
* Chris Deline (:ghuser:`cdeline`)
* Ioannis Sifnaios (:ghuser:`IoannisSifnaios`)
* Leonardo Micheli (:ghuser:`lmicheli`)
* Echedey Luis (:ghuser:`echedey-ls`)
Expand Down
10 changes: 9 additions & 1 deletion pvlib/bifacial/loss_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def power_mismatch_deline(
where the upper equation is in percentage (same as paper) and the lower
one is unitless. The implementation uses the unitless version, where
:math:`M[-]` is the mismatch power loss [unitless] and
:math:`\Delta[-]` is the Relative Mean Absolute Difference [unitless]
:math:`\Delta[-]` is the Relative Mean Absolute Difference (RMAD) [unitless]
of the global irradiance, Eq. (4) of [1]_ and [2]_.
Note that the n-th power coefficient is multiplied by :math:`100^{n-1}`
to convert the percentage to unitless.
Expand Down Expand Up @@ -101,6 +101,14 @@ def power_mismatch_deline(
The global irradiance RMAD is different from the backside irradiance
RMAD.

RMAD of a variable :math:`G_{total}` is defined as:

.. math::

RMAD \left[ unitless \right] = \Delta \left[ unitless \right] =
\frac{1}{n^2 \bar{G}_{total}} \sum_{i=1}^{n} \sum_{j=1}^{n}
\lvert G_{total,i} - G_{total,j} \rvert

In case the RMAD of the backside irradiance is known, the global RMAD can
be calculated as follows, assuming the front irradiance RMAD is
negligible [2]_:
Expand Down
Loading