-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add style guide for references in contributing/style_guide.rst
#2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Questions: |
No, but a bit wordy in places. I can edit if you'd like.
Yes. I think add a book or book chapter, and a technical report from some lab.
I don't see why not. |
Sure, please go ahead
Okay will do |
contributing.rst
contributing.rst
Co-authored-by: Cliff Hansen <[email protected]>
Co-Authored-By: Cliff Hansen <[email protected]>
I think we should encourage users not to format it manually, but perhaps use something like this: https://citation.crosscite.org/ Also, the DOI should be required if there is one. Last, might be a good idea to link to the official IEEE description: https://journals.ieeeauthorcenter.ieee.org/wp-content/uploads/sites/7/IEEE_Reference_Guide.pdf The official guide (above) states the following, which we should abide by:
|
Do we want pvlib to endorse one particular citation generator though...? I think most people would be aware of such sites and just go ahead and use one themselves if they want to.
Already included, see line 85
Already included, see line 78 in the original, 77 since the last commit
Have now added it in (line 81) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is OK with me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like so many details aren't necessary. In fact, so many details on how IEEE work may encourage contributors to manually type the citations. But I can live with that.
Do we want pvlib to endorse one particular citation generator though...?
I'd say we don't want to, but citing "Use of a citation generator is recommended" at least somewhere would be nice. Whether or not to provide a link... dunno. I wouldn't put it just as there are plenty of them.
In addition, maybe add Zotero, other bib managers or the published paper webpage as sources to get the IEEE citation from.
LGTM nevertheless, this section would definitely be remembered for whoever reads it!
On a couple of recent PRs to another repo I've been using the IEEE citation format... and I really dislike how the first name initial comes first. It seems that most pvlib functions already are using a somewhat fairly consistent format - anyone know what that is? |
Likely, just imitating other references. There hasn't been a citation style specified or requested before. |
@AdamRJensen I also think the initial/name order is a slightly odd, it's not what I am used to anyway, but it's not a dealbreaker for me. I think IEEE is still a good choice. Is there another style you'd recommend? |
What would be cool is a Zotero group or library that we could share with pvlib users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be cool is a Zotero group or library that we could share with pvlib users
@mikofski I'm completely ignorant on that feature of Zotero, but the bibtex file with references in pvlib would be super for that? I mean, centralized in the repo so nobody ever forgets about updating it, in the same PRs that get accepted, and for those non-Zotero users a webpage with all the references to find if a paper is or not relevant in pvlib / a model is a good candidate.
I would vote for the APA style. Here's an example: IEEE Style: APA Style: Vote this post up if you agree with APA and vote down if you prefer IEEE. |
Personally, I think the APA style is easier to read. But I'm voting for IEEE because 1) IEEE publishes the many of the references cited, 2) IEEE lets one export the citation but only in the IEEE format. If we choose APA, then I need to edit the citation rather than just copy/paste. |
also full stops (required except in the case of ending with a URL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition, very helpful!
@RDaxini thumb up this post and I'll merge this PR in a couple of days.
contributing.rst
contributing/style_guide.rst
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.