-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Show distribution file sizes in publish.yml
GH Actions workflow
#2278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The publish job now shows filesizes for the distribution files:
and installed files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea and nice PR. Minor suggestions down below, feel free to discard them. I would prefer to have all the sizes in the same step so it gets expanded in a click, but it's fine as is.
Co-authored-by: Echedey Luis <[email protected]>
Seems like there are no objections here, so I will go ahead and merge. Thanks for the review @echedey-ls! |
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.With ongoing work around reducing the size of our distribution files, it is helpful to log the filesize in PR dist builds.