Skip to content

Make dni_extra a required parameter for ghi_from_poa_driesse_2023 #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Make dni_extra a required parameter for ghi_from_poa_driesse_2023 #2331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21cf3bd
make dni_extra a required parameter
IoannisSifnaios Dec 12, 2024
ed0b6ce
update whatsnew
IoannisSifnaios Dec 12, 2024
083276f
Update docs/sphinx/source/whatsnew/v0.11.2.rst
IoannisSifnaios Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/sphinx/source/whatsnew/v0.11.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ Bug Fixes
(:issue:`1338`, :pull:`2227`)
* Handle DST transitions that happen at midnight in :py:func:`pvlib.solarposition.hour_angle`
(:issue:`2132` :pull:`2133`)
* Changed ``dni_extra`` to a required parameter in :py:func:`pvlib.irradiance.ghi_from_poa_driesse_2023`
(:issue:`2279` :pull:`2331`)

Bug fixes
~~~~~~~~~
Expand Down Expand Up @@ -85,3 +87,4 @@ Contributors
* Echedey Luis (:ghuser:`echedey-ls`)
* Kevin Anderson (:ghuser:`kandersolar`)
* Scott Nelson (:ghuser:`scttnlsn`)
* Ioannis Sifnaios (:ghuser:`IoannisSifnaios`)
4 changes: 2 additions & 2 deletions pvlib/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,7 +1528,7 @@ def poa_error(ghi):
def ghi_from_poa_driesse_2023(surface_tilt, surface_azimuth,
solar_zenith, solar_azimuth,
poa_global,
dni_extra=None, airmass=None, albedo=0.25,
dni_extra, airmass=None, albedo=0.25,
xtol=0.01,
full_output=False):
'''
Expand All @@ -1549,7 +1549,7 @@ def ghi_from_poa_driesse_2023(surface_tilt, surface_azimuth,
Solar azimuth angle. [degree]
poa_global : numeric
Plane-of-array global irradiance, aka global tilted irradiance. [Wm⁻²]
dni_extra : numeric, optional
dni_extra : numeric
Extraterrestrial direct normal irradiance. [Wm⁻²]
airmass : numeric, optional
Relative airmass (not adjusted for pressure). [unitless]
Expand Down
Loading