-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add semi_integrated
parameters for PVsyst temperature model
#2415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semi_integrated
parameters for PVsyst temperature model
#2415
Conversation
Hi @Muhammad-Rebaal there's a lot that needs to be done differently here.
|
Oh my bad ! Actually, I changed those stuff but it wasn't pushed by me 😬 |
Sorry @Muhammad-Rebaal for the delay. I hope you don't mind that I've edited this PR to be closer to what I think @cwhanse was describing. Ready for review again. |
semi_integrated
parameters for PVsyst temperature model
Thanks @Muhammad-Rebaal! |
My pleasure 🙌🏻 |
Hi @cwhanse !
Hope you are doing well !
I've open a PR for the enhancement asked in the issue #2330 for semi_integration model for roof top mounted systems and also write the test for it . So, Could you please take a look at it & let me if anything needs to change ?
Thank You !