Skip to content

Add semi_integrated parameters for PVsyst temperature model #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Muhammad-Rebaal
Copy link
Contributor

Hi @cwhanse !

Hope you are doing well !

I've open a PR for the enhancement asked in the issue #2330 for semi_integration model for roof top mounted systems and also write the test for it . So, Could you please take a look at it & let me if anything needs to change ?

Thank You !

@cwhanse
Copy link
Member

cwhanse commented Mar 21, 2025

Hi @Muhammad-Rebaal there's a lot that needs to be done differently here.

  1. The parameters for the semi-integrated case need to be added to the dict here
  2. The docstring of temperature.pvsyst_cell needs to have the semi-integrated case added.
  3. The docstring and methods of pvsystem/PVSystem need to have semi-integrated added as an option for racking_model. You can locate where by searching for one of the existing parameter names for the PVsyst temperature model, e.g. freestanding
  4. The unit test should only test that the correct parameters are inferred when racking_model is semi-integrated. That test goes here. The correct calculation by the pvsyst_cell function is already tested.

@Muhammad-Rebaal
Copy link
Contributor Author

Muhammad-Rebaal commented Mar 21, 2025

Hi @Muhammad-Rebaal there's a lot that needs to be done differently here.

  1. The parameters for the semi-integrated case need to be added to the dict here
  2. The docstring of temperature.pvsyst_cell needs to have the semi-integrated case added.
  3. The docstring and methods of pvsystem/PVSystem need to have semi-integrated added as an option for racking_model. You can locate where by searching for one of the existing parameter names for the PVsyst temperature model, e.g. freestanding
  4. The unit test should only test that the correct parameters are inferred when racking_model is semi-integrated. That test goes here. The correct calculation by the pvsyst_cell function is already tested.

Oh my bad ! Actually, I changed those stuff but it wasn't pushed by me 😬
Thank you for your assistance @cwhanse

@kandersolar kandersolar added this to the v0.12.1 milestone May 7, 2025
@kandersolar
Copy link
Member

Sorry @Muhammad-Rebaal for the delay. I hope you don't mind that I've edited this PR to be closer to what I think @cwhanse was describing.

Ready for review again.

@kandersolar kandersolar changed the title Enhanced the Software with Semi-Integration Add semi_integrated parameters for PVsyst temperature model May 7, 2025
@kandersolar kandersolar merged commit a89e3c4 into pvlib:main May 7, 2025
31 checks passed
@kandersolar
Copy link
Member

Thanks @Muhammad-Rebaal!

@Muhammad-Rebaal
Copy link
Contributor Author

Thanks @Muhammad-Rebaal!

My pleasure 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants