-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add single axis tracking #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A lot of changes since the initial PR.
It would be helpful for somebody to make an initial review at this point. |
What if the given elevation and azimuth don't have the same index? Could run into problems when doing things like finding wid. I would suggest ensuring/forcing |
@alorenzo175 pointed out that the I expect that the tests will fail since I didn't update the expected values. I'll make the other changes too. |
Updated the tests and added a few lines for @alorenzo175. Added introduction material to notebook. |
Added the same examples as the PVLIB MATLAB 1.2 help file to the tutorial. Updated internal variable names to be consistent with PEP8 and, I think, make the algorithm more understandable. Also replaced lots of I think this is close to being ready to merge. |
Rebased so that the test run against all of the pandas versions. Removed the latitude kwarg since I don't think it's necessary. I am happy to make changes, but if there are no objections to merging then let's go ahead and do it. |
This PR contains a Python implementation of PVLIB MATLAB's
pvl_singleaxis.m
. This isn't yet ready to merge (needs tests and PEP8), but I wanted to share progress and provide a place for feedback.The code and comments are very similar to
pvl_singleaxis.m
. I think that some things can be simplified, but I wanted to get something working first. Sandia put a lot of comments in the code and I'm inclined to keep most of them.I believe that the AOI calculation is correct, but there's something wrong with the surface azimuth and tilt calculation.
Here's an IPython notebook that explores most of the parameters.