Skip to content

make test_forecast.py more robust, warn problems instead of fail #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2018

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Aug 6, 2018

  • Closes make test_forecast.py more robust #293
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):

This PR should resolve the majority of the intermittent test failures due to test_forecast.py. The errors will now be recorded as warnings. This is not ideal but I think it's acceptable.

I tested that all of the warnings are printed when I force exceptions in the try blocks.

@wholmgren wholmgren added this to the 0.6.0 milestone Aug 6, 2018
@wholmgren wholmgren requested a review from cwhanse August 6, 2018 23:42
@wholmgren
Copy link
Member Author

Example of printed warning instead of a fail: https://travis-ci.org/pvlib/pvlib-python/jobs/412887886

@wholmgren wholmgren merged commit f57f4c6 into pvlib:master Aug 7, 2018
@wholmgren wholmgren deleted the testforecastflex branch August 7, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make test_forecast.py more robust
2 participants