-
Notifications
You must be signed in to change notification settings - Fork 1.1k
documentation fixes #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
documentation fixes #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly ipython version specific
cwhanse
reviewed
Dec 10, 2018
@@ -43,6 +46,7 @@ Enhancements | |||
isobaric values and modeled wind speed instead of inferring from gust. | |||
(:issue:`604`) | |||
* Change :py:func:`pvlib.pvsystem.sapm_spectral_loss` to avoid numpy warning. | |||
* Add warning message when :py:func:`pvlib.spa` is reloaded. (:issue:`401`) | |||
* Add warning message when :py:func:`pvlib.spa` is reloaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant line here
cwhanse
approved these changes
Dec 10, 2018
@cwhanse thanks for the review. |
Confirmed that documentation successfully builds again. The issue with some of the IPython output being hidden (and inputs all labeled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a handful of issues with the documentation.
Readthedocs has not built the documentation on
master
for the last couple of months. This PR should fix that. I think the major thing that broke the docs was IPython 7 becoming available and it being less tolerant of warnings and errors.Here's a link to the built documentation on my fork: https://wholmgren-pvlib-python-new.readthedocs.io/en/docfix/
I'll merge in a few days if I don't hear any feedback.
docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
file for all changes.