Skip to content

documentation fixes #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 10, 2018
Merged

documentation fixes #632

merged 12 commits into from
Dec 10, 2018

Conversation

wholmgren
Copy link
Member

Fix a handful of issues with the documentation.

Readthedocs has not built the documentation on master for the last couple of months. This PR should fix that. I think the major thing that broke the docs was IPython 7 becoming available and it being less tolerant of warnings and errors.

Here's a link to the built documentation on my fork: https://wholmgren-pvlib-python-new.readthedocs.io/en/docfix/

I'll merge in a few days if I don't hear any feedback.

  • no issue to close
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren wholmgren added this to the 0.6.1 milestone Dec 8, 2018
@@ -43,6 +46,7 @@ Enhancements
isobaric values and modeled wind speed instead of inferring from gust.
(:issue:`604`)
* Change :py:func:`pvlib.pvsystem.sapm_spectral_loss` to avoid numpy warning.
* Add warning message when :py:func:`pvlib.spa` is reloaded. (:issue:`401`)
* Add warning message when :py:func:`pvlib.spa` is reloaded.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant line here

@wholmgren
Copy link
Member Author

@cwhanse thanks for the review.

@wholmgren wholmgren merged commit ef82a39 into pvlib:master Dec 10, 2018
@wholmgren wholmgren deleted the docfix branch December 10, 2018 15:40
@wholmgren
Copy link
Member Author

Confirmed that documentation successfully builds again. The issue with some of the IPython output being hidden (and inputs all labeled [1]) has also disappeared (first seen in #568). I suspect that they are related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants