Skip to content

irradiance.py added function for SMARTS Spectra #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shirubana
Copy link

Example for Tucson AZ, 06/21/2001 at Noon, direct and diffuse spectra:

E_theor=SMARTSSpectra('2 3','2001','6','21','12','32.','-110.92')

  • Closes SMARTS wrapper function #857
  • I am familiar with the contributing guidelines
  • [0 ] Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Example for Tucson AZ, 06/21/2001 at Noon, direct and diffuse spectra:

 E_theor=SMARTSSpectra('2 3','2001','6','21','12','32.','-110.92')
@mikofski mikofski mentioned this pull request Feb 15, 2020
8 tasks
@CameronTStark CameronTStark added this to the Someday milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMARTS wrapper function
2 participants