Spa.julian day microsecond fix #942
Conversation
… test in tests_spa to check for correct scaling
There was a problem hiding this comment.
Thanks @ericf900! One minor formatting comment below. It might also be a good idea to note in the whatsnew that this function is not used in the typical SPA solar position workflow so users shouldn't expect their old results to be wrong, but I'll leave it to others to decide if it's needed and if so what the wording should be.
| @@ -60,6 +62,8 @@ Testing | |||
| dependent iotools tests to repeat them on failure. (:pull:`919`) | |||
| * Separate azure-pipelines.yml platform-specific tests to their own templates | |||
| located in ``./ci/azure/``. (:pull:`926`) | |||
| * Updated test_julian_day_dt in spa_test to check for correct microsecond | |||
| scaling (:issue:`940') (:pull:`942`) | |||
There was a problem hiding this comment.
Accidentally used apostrophe here instead of backtick, check the formatting here: https://pvlib-python--942.org.readthedocs.build/en/942/whatsnew.html#testing
There was a problem hiding this comment.
Same for the entry in "bug fixes"
There was a problem hiding this comment.
no need to make a separate what's new entry for the test fix.
There was a problem hiding this comment.
Thanks Will and Kevin! I made those changes
| @@ -60,6 +62,8 @@ Testing | |||
| dependent iotools tests to repeat them on failure. (:pull:`919`) | |||
| * Separate azure-pipelines.yml platform-specific tests to their own templates | |||
| located in ``./ci/azure/``. (:pull:`926`) | |||
| * Updated test_julian_day_dt in spa_test to check for correct microsecond | |||
| scaling (:issue:`940') (:pull:`942`) | |||
There was a problem hiding this comment.
no need to make a separate what's new entry for the test fix.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).