Skip to content

Refactor clearsky.py #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2015
Merged

Conversation

wholmgren
Copy link
Member

This PR:

I ran the new assert_frame_equals tests against both the old and the new versions of clearsky.py, so I'm confident that the refactoring has not changed the output of the ineichen function.

I still need to:

  • add some test functions for the new lookup_linke_turbidity function
  • add a numeric test for the haurwitz function.
  • update what's new

@wholmgren wholmgren added this to the 0.3 milestone Nov 5, 2015
@wholmgren
Copy link
Member Author

Ok, I think this is now good to go, but I'll welcome any comments. I'll merge or Monday or Tuesday unless I hear objections.

Note that I also added a line to whatsnew for @jetheurer's contribution in #94. I should have remembered that needed to be done before merging #94.

cc @cwhanse

wholmgren added a commit that referenced this pull request Nov 11, 2015
@wholmgren wholmgren merged commit 2314467 into pvlib:master Nov 11, 2015
@wholmgren wholmgren deleted the refactor-turbidity branch January 23, 2016 18:28
@wholmgren wholmgren modified the milestones: 0.2.2, 0.3.0 Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move linke turbidity lookup out of clearsky.ineichen
1 participant