Skip to content

set build dir #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2019
Merged

set build dir #6

merged 2 commits into from
Jul 21, 2019

Conversation

pwright
Copy link
Owner

@pwright pwright commented Jul 21, 2019

Motivation

Add references to relevant tickets or a short description about what motivated you do it. (E.g JIRA: https://issues.jboss.org/browse/AEROGEAR-{} AND/OR ISSUE: https://github.com/aerogear/standards/issues/{})

What

Add an short answer for: What was done in this PR? (E.g Don't allow users has access to the feature X.)

Why

Add an short answer for: Why it was done? (E.g The feature X was deprecated.)

How

Add an short answer for: How it was done? (E.g By removing this feature from ... OR By removing just the button but not its implementation ... )

Verification Steps

Add the steps required to check this change. Following an example.

  1. Go to XX >> YY >> SS
  2. Create a new item N with the info X
  3. Try to edit this item
  4. Check if in the left menu the feature X is not so long present.

Checklist:

  • Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

Progress

  • Finished task
  • TODO

Additional Notes

PS.: Add images and/or .gifs to illustrate what was changed if this pull request modifies the appearance/output of something presented to the users.

@pwright pwright merged commit 1b53d68 into master Jul 21, 2019
pwright pushed a commit that referenced this pull request Jul 21, 2019
This reverts commit 1b53d68.
@pwright pwright mentioned this pull request Jul 21, 2019
pwright pushed a commit that referenced this pull request Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants