-
Notifications
You must be signed in to change notification settings - Fork 62
tutorial RSS feeds #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tutorial RSS feeds #488
Conversation
I turned off |
@sneakers-the-rat thank you so so much!! I know so many people who dislike pre-commit. I love it for the pre-commit CI bot, which is useful for contributors who don't want to install or mess with pre-commit and linting in their dev environments. I totally get the challenge of troubleshooting bugs. Thank you for doing this. It will save me so much time trying to manually update our learning resources page. I will test it out and also help fill in the missing descriptions, dates, and other details in the original headers. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great locally! let's merge!
_ext/rss.py
Outdated
title=meta[":og:title"], | ||
description=meta[":og:description"], | ||
date=datetime.fromisoformat(meta["date"]), | ||
author=meta.get(":og:author", "PyOpenSci"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
author=meta.get(":og:author", "PyOpenSci"), | |
author=meta.get(":og:author", "pyOpenSci"), |
Ok the point of failures here are link related error code 200's (hashes that it can't find). We are ok to go ahead and merge. |
@sneakers-the-rat thank you again for this!!! |
fix: #153
i saw something with allcaps PRIORITY! and was like "oh i know how to do that.
so i slightly modified the linked PEP example and just made it dataclasses so we know whats goin on yno.
I think in general treating first paragraphs of things as descriptions the same way i think dumping a bunch of PR titles in a document and calling it a changelog - it technically satisfies the thing you were trying to do, but it isn't all that useful for that purpose. So, two at once, freebie style, i figure if we define an opengraph title and description we can just use them in the feed.
You'll see a bunch of placeholder text in the tutorial item pages - that should be changed to be an actual description instead of placeholder text!
but ya anyway this builds an rss feed into
/tutorials.rss
that looks like thisexpand/collapse rss