-
Notifications
You must be signed in to change notification settings - Fork 2.2k
FindPythonLibsNew.cmake not working with MSYS Python interpreter #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
this doesn't work on MSYS2 CMake Error at tools/FindPythonLibsNew.cmake:158 (message): |
same issue-- my underlying C++ code gets about a 2x speedup when compiling with gcc (via MinGW) versus visual studio, but I can't generate python bindings for it, because of these errors and incompatibility with MinGW. What would need to change to support the MinGW toolchain on Windows? |
FTR MSYS2 is now packaging patched pybind11 |
@wojdyr , @samuelpmish , @xiaowen64, @fteicht : would you be able to test @kanonet's PR #1851 and provide feedback on whether the issue is completely resolved after that? |
What will happen if they do not answer? Will my fix get released? Is there anything I can do? |
closed via #1851 |
FindPythonLibsNew.cmake tests for windows system (CMAKE_HOST_WIN32 is true) then it assumes that the Python interpreter works with windows-like directories hierarchy (lines 141-143).
However, it does not work when using MSYS' python interpreter which assumes a Unix-like directories hierarchy.
Note that compiling python bindings with MSYS' mingw compiler requires to use MSYS' python interpreter. For instance, anaconda's interpreter's include files do not need to be compatible with MSYS' compiler due to version mismatch.
The text was updated successfully, but these errors were encountered: