Skip to content

[BUG]: Inaccurate doc on unchecked(). #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xkszltl opened this issue Feb 19, 2023 · 0 comments · Fixed by #4519
Closed

[BUG]: Inaccurate doc on unchecked(). #4518

xkszltl opened this issue Feb 19, 2023 · 0 comments · Fixed by #4519
Labels
triage New bug, unverified

Comments

@xkszltl
Copy link
Contributor

xkszltl commented Feb 19, 2023 •
edited
Loading

Problem description

This line probably means mutable_unchecked(), not unchecked().
@xkszltl xkszltl added the triage New bug, unverified label Feb 19, 2023
xkszltl added a commit to xkszltl/pybind11 that referenced this issue Feb 19, 2023
@xkszltl
Inconsistent comments between 2 templates of unchecked().
4f47425 
This comment is unrelated to having T in tparam or not.
Probably a typo.
Copied the correct one here.

Resolve pybind#4518
@xkszltl xkszltl mentioned this issue Feb 19, 2023
Merged
rwgk pushed a commit that referenced this issue Feb 20, 2023
@xkszltl
Inconsistent comments between 2 templates of unchecked(). (#4519)
a19daea 
This comment is unrelated to having T in tparam or not.
Probably a typo.
Copied the correct one here.

Resolve #4518
henryiii pushed a commit that referenced this issue Feb 24, 2023
@xkszltl @henryiii
Inconsistent comments between 2 templates of unchecked(). (#4519)
b596235 
This comment is unrelated to having T in tparam or not.
Probably a typo.
Copied the correct one here.

Resolve #4518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage New bug, unverified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inconsistent comments between 2 templates of unchecked(). xkszltl/pybind11
1 participant
@xkszltl